1192353 - make HyperTextProxyAccessibleWrap inherit from HyperTextAccessibleWrap

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Trevor Saunders (:tbsaunde)]

This is rather unfortunate, AccessibleWrap itself wastes a fair amount of space
when it just stores a pointer to a proxy, and this makes it waste even more.
However this is rather necessary for now because we need to be able to downcast
classes such as ia2AccessibleText to one type that works both when the
accessible is pointing to a proxy and when it is not.  That means
HyperTextAccessibleWrap and HyperTextProxyAccessibleWrap need to have the same
layout.

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: make HyperTextProxyAccessibleWrap inherit from HyperTextAccessibleWrap

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8645082 [details] [diff] [review]
make HyperTextProxyAccessibleWrap inherit from HyperTextAccessibleWrap

Review of attachment 8645082 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/windows/ProxyWrappers.h
@@ +34,5 @@
>    HyperTextProxyAccessibleWrap(ProxyAccessible* aProxy) :
> +    HyperTextAccessibleWrap(nullptr, nullptr)
> +  {
> +    mType = eProxyType;
> +    mBits.proxy = aProxy;

How do we remember to update this if we update ProxyAccessibleWrap?

Comment 3

[Trevor Saunders (:tbsaunde)]

(In reply to David Bolter [:davidb] from comment #2)
> Comment on attachment 8645082 [details] [diff] [review]
> make HyperTextProxyAccessibleWrap inherit from HyperTextAccessibleWrap
> 
> Review of attachment 8645082 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/windows/ProxyWrappers.h
> @@ +34,5 @@
> >    HyperTextProxyAccessibleWrap(ProxyAccessible* aProxy) :
> > +    HyperTextAccessibleWrap(nullptr, nullptr)
> > +  {
> > +    mType = eProxyType;
> > +    mBits.proxy = aProxy;
> 
> How do we remember to update this if we update ProxyAccessibleWrap?

update in what way?  The only way you'd necesarrily need to change both is if you reorganize the IsProxy() / mBits.proxy stuff, in which case obviously you need to look at everything that touches that.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d2b9ae330a2

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6d2b9ae330a2