Closed Bug 1192356 Opened 4 years ago Closed 4 years ago

Use Tie() in ImageLib code

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: seth, Assigned: seth)

References

Details

Attachments

(2 files)

Now that bug 1185706 has landed, we can use Tie() in the SurfaceCache code that was intended to use it before I discovered that it previously wasn't available on all platforms.
Here's the patch. Much nicer using Tie().
Attachment #8645097 - Flags: review?(dholbert)
Summary: Use Tie() in SurfaceCache code → Use Tie() in ImageLib code
We can also take advantage of Tie() in RasterImage. Let's do that too.
Attachment #8645114 - Flags: review?(tnikkel)
Attachment #8645114 - Flags: review?(tnikkel) → review+
Comment on attachment 8645097 [details] [diff] [review]
Take advantage of mozilla::Tie() in SurfaceCache.cpp

Nice syntactic sugar! r=me, just one nit, which you might've already fixed:

>Bug 1192356 - Take advantage of mozilla::Tie() in SurfaceCache.cpp. r=dholbert

This ^^^ probably wants "(Part 1)" for consistency with your Part 2 commit message.
Attachment #8645097 - Flags: review?(dholbert) → review+
Thanks for the reviews!

(In reply to Daniel Holbert [:dholbert] from comment #3)
> This ^^^ probably wants "(Part 1)" for consistency with your Part 2 commit
> message.

Fixed locally. Felt bad reuploading the patch just to slightly change the commit message. =)
https://hg.mozilla.org/mozilla-central/rev/c84a03221fb3
https://hg.mozilla.org/mozilla-central/rev/d4743fcc524c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.