1192375 - Refector save classification to update Annotations correctly

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Jonathan French (:jfrench)]

In feature work for job chunking in bug 1163064, to support correct n,p unclassified navigation, we'd like to try to get save classification working correctly without 'passive' job selection implemented as part of bug 1164166.

https://github.com/mozilla/treeherder/blob/master/ui/plugins/pinboard.js#L81

Without a refactor, after a save classification on a collapsed job chunk which reselects the job, n,p will always incorrectly navigate to the top of the DOM rather than continue to the next unclassified failure - since the collapsed job chunk is no longer in the DOM when its +n count is collapsed.

If I've misrepresented anything camd, feel free to clarify :)

Comment 2

[Cameron Dawson [:camd]]

Attachment: PR

Comment 3

[Jonathan French (:jfrench)]

Comment on attachment 8646576 [details] [review]
PR

r+ with optional tweaks addressed, it tested well on stage and I added what was tested to the PR conversation.

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/353fc3773a4bd3d86d36921ad102581754cda72c
Bug 1192375 - Refactor save classification to update Annotations correctly

Comment 5

[Jonathan French (:jfrench)]

Marking fixed per above merge.

Comment 6

[Jonathan French (:jfrench)]

And I'll call this verified fixed on stage, since the branch testing occurred there.