Closed Bug 1192400 Opened 7 years ago Closed 5 years ago

Fix the issue with waiting for keyboard in system/test/marionette/activity_action_menu_test.js

Categories

(Testing Graveyard :: JSMarionette, defect)

Product:
Testing Graveyard
Component:
JSMarionette
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 affected)

Status:
RESOLVED INCOMPLETE
Tracking Flags:
Tracking Status
firefox42 --- affected

People

(Reporter: yzen, Unassigned)

References

Details

Attachments

(3 files)

[gaia] yzen:bug-1192400 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
gaye
: review+
Details | Review
[gaia] yzen:bug-1192400 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
yzen
: review+
Details | Review
[gaia] yzen:bug-1192400 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
Details | Review 
The test is failing because we are not in the right frame when waiting for the keyboard. We need to ensure that this is not an issue even if we are in a different app frame.
Attachment #8645169 - Flags: review?(gaye)
Awesome work! From a first look, pr looks great, but I want to take a closer look in a bit.
Comment on attachment 8645169 [details] [review]
[gaia] yzen:bug-1192400 > mozilla-b2g:master

Great work again!
Attachment #8645169 - Flags: review?(gaye) → review+
Comment on attachment 8645169 [details] [review]
[gaia] yzen:bug-1192400 > mozilla-b2g:master

Meant to r+ the other one first.
Attachment #8645169 - Flags: review+ → review?
Comment on attachment 8645169 [details] [review]
[gaia] yzen:bug-1192400 > mozilla-b2g:master

Also LGTM but seems to be breaking some keyboard test. Once you take a look at that (and fix the jshint issue(s)), feel free to land. Thanks for the work!
Attachment #8645169 - Flags: review? → review+
https://github.com/mozilla-b2g/gaia/pull/31291
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Backed out for activity_action_menu_test.js permafail.
https://treeherder.mozilla.org/logviewer.html#?job_id=2559051&repo=b2g-inbound

Master: https://github.com/mozilla-b2g/gaia/commit/8f77edf3ac39d36f6df0f5517223d3ed35ed89e0
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8651904 [details] [review]
[gaia] yzen:bug-1192400 > mozilla-b2g:master

Carrying over the review from the backed out PR (it looks like the base revision was not new enough for the tests to pass).
Attachment #8651904 - Flags: review+
https://github.com/mozilla-b2g/gaia/commit/ca5bd58200df4d61e15ccaf8ba500cf483337cfc
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
Re-enabling still causing issues in bug 1168363 (this is unrelated to the keyboard frame fix).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: yzenevich → nobody
Bulk closed as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1422750
Status: REOPENED → RESOLVED
Closed: 7 years ago → 5 years ago
Resolution: --- → INCOMPLETE
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.