Fix the issue with waiting for keyboard in system/test/marionette/activity_action_menu_test.js

REOPENED
Unassigned

Status

Testing
JSMarionette
REOPENED
2 years ago
2 years ago

People

(Reporter: yzen, Unassigned)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 affected)

Details

Attachments

(3 attachments)

(Reporter)

Description

2 years ago
The test is failing because we are not in the right frame when waiting for the keyboard. We need to ensure that this is not an issue even if we are in a different app frame.
Created attachment 8645169 [details] [review]
[gaia] yzen:bug-1192400 > mozilla-b2g:master
(Reporter)

Updated

2 years ago
Attachment #8645169 - Flags: review?(gaye)
Awesome work! From a first look, pr looks great, but I want to take a closer look in a bit.
Comment on attachment 8645169 [details] [review]
[gaia] yzen:bug-1192400 > mozilla-b2g:master

Great work again!
Attachment #8645169 - Flags: review?(gaye) → review+
Comment on attachment 8645169 [details] [review]
[gaia] yzen:bug-1192400 > mozilla-b2g:master

Meant to r+ the other one first.
Attachment #8645169 - Flags: review+ → review?
Comment on attachment 8645169 [details] [review]
[gaia] yzen:bug-1192400 > mozilla-b2g:master

Also LGTM but seems to be breaking some keyboard test. Once you take a look at that (and fix the jshint issue(s)), feel free to land. Thanks for the work!
Attachment #8645169 - Flags: review? → review+
(Reporter)

Comment 6

2 years ago
https://github.com/mozilla-b2g/gaia/pull/31291
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Backed out for activity_action_menu_test.js permafail.
https://treeherder.mozilla.org/logviewer.html#?job_id=2559051&repo=b2g-inbound

Master: https://github.com/mozilla-b2g/gaia/commit/8f77edf3ac39d36f6df0f5517223d3ed35ed89e0
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 8651904 [details] [review]
[gaia] yzen:bug-1192400 > mozilla-b2g:master
(Reporter)

Comment 9

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4bfe3dd1c2f
(Reporter)

Comment 10

2 years ago
Comment on attachment 8651904 [details] [review]
[gaia] yzen:bug-1192400 > mozilla-b2g:master

Carrying over the review from the backed out PR (it looks like the base revision was not new enough for the tests to pass).
Attachment #8651904 - Flags: review+
(Reporter)

Comment 11

2 years ago
https://github.com/mozilla-b2g/gaia/commit/ca5bd58200df4d61e15ccaf8ba500cf483337cfc
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
Created attachment 8654145 [details] [review]
[gaia] yzen:bug-1192400 > mozilla-b2g:master
(Reporter)

Comment 13

2 years ago
Re-enabling still causing issues in bug 1168363 (this is unrelated to the keyboard frame fix).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Updated

2 years ago
Assignee: yzenevich → nobody
You need to log in before you can comment on or make changes to this bug.