Closed Bug 1192466 Opened 4 years ago Closed 4 years ago

Prune header includes for SkiaGLGlue.h

Categories

(Core :: Graphics, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

Attachments

(1 file, 1 obsolete file)

This includes a bunch of Skia headers, but it doesn't have to.

This touches something in moz2d, so let's have :bas review it.
Attachment #8645275 - Flags: review?(bas)
Bas is heading to SIGGRAPH so this review might take some time. If you don't want to wait it's probably best to just have me or jrmuizel review it.
Turns out removing headers from sources means accidental dependencies fail!
Attachment #8645275 - Attachment is obsolete: true
Attachment #8645275 - Flags: review?(bas)
Attachment #8645283 - Flags: review?(bas)
Comment on attachment 8645283 [details] [diff] [review]
0004-Minimize-includes-for-SkiaGLGlue.h.patch

Review of attachment 8645283 [details] [diff] [review]:
-----------------------------------------------------------------

Ok.
Attachment #8645283 - Flags: review?(bas) → review?(bgirard)
Comment on attachment 8645283 [details] [diff] [review]
0004-Minimize-includes-for-SkiaGLGlue.h.patch

Review of attachment 8645283 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, as far as I can tell we're not changing the behavior of anything.

::: gfx/2d/RefPtrSkia.h
@@ +6,5 @@
> +#ifndef MOZILLA_GFX_REFPTRSKIA_H_
> +#define MOZILLA_GFX_REFPTRSKIA_H_
> +
> +/*
> +#include "2D.h"

Did you forget to remove this?
Attachment #8645283 - Flags: review?(bgirard) → review+
Yep, removed now.
https://hg.mozilla.org/mozilla-central/rev/8a08928bb914
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.