119250 - javascript strict warnings in mailWindowOverlay.js

Status: VERIFIED DUPLICATE of bug 68525

(SeaMonkey :: MailNews: Message Display, defect)

Description

[K Chayka]

win32 build 2002011003, win98se

The following displays twice in the js console when mail is first started:

Error: Components.classes['@mozilla.org;timeline-service;1'] has no properties
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 34

This has been in the last several builds, I think.

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

Confirming, I've seen this too, but I *think* it's harmless. DP would know...

Comment 2

[Suresh Duddi (gone)]

Timeline is enabled only in DEBUG builds of windows by default. On the rest it
is enabled with MOZ_TIMELINE or --enable-timeline is set...

C++ code that doesn't have timeline just noops out. But for js there is no such
facility. Look like mailwindowOverlay.js is using timeline and is checked in.

It is harmless but I wouldnt expect this code to be run in non-debug builds.

Comment 3

[Matthias Versen [:Matti]]

*** Bug 119386 has been marked as a duplicate of this bug. ***

Comment 4

[Henrik Gemal]

There are both javascript warnings and errors. Messing up the console.
I'm using a nightly build so the timeline shouldn't be there right?

Warning: reference to undefined property
Components.classes['@mozilla.org;timeline-service;1']
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 34

Error: Components.classes['@mozilla.org;timeline-service;1'] has no properties
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 34

Comment 5

[Antonio Lam]

This bug is preventing me from running my JavaScript S/MIME automated test. It 
failed to launch the Messenger window when running the following JavaScript 
code:

setTimeout(lastWindow.OpenMessenger,1);
setTimeout(closeAlert,4000);
alert('Loading Messenger window... Will close automatically.');

The last workable build for me is 2001121103.

Fixing this bug is critical for me to continue the S/MIME automation effort. 
Thanks.

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

Varada should own this, but he's currently on sabbatical.

Comment 7

[Suresh Duddi (gone)]

Attachment: Draft patch...

Something like this should get this through. I haven't tested it or anything.

Comment 8

[Antonio Lam]

Any update on this bug?

Comment 9

[lchiang]

Looks like DP has a patch.  Who can review this?

Comment 10

[scottputterman]

Sean, could you review this and then pass it on for the super review?

Comment 11

[Jimmy Lee]

Any new news?  Thanks!

Comment 12

[Antonio Lam]

Tried with today's trunk build (2002020110), and this problem seems is gone.  I 
am able to run my JavaScript S/MIME automated test now.

Comment 13

[Phil Schwartau]

*** Bug 124137 has been marked as a duplicate of this bug. ***

Comment 14

[scottputterman]

marking WFM based on comments.

Comment 15

[[e-mail] (gone - use [e-mail] instead)]

Well... I still see

Warning: reference to undefined property
Components.classes['@mozilla.org;timeline-service;1']
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 39

Perhaps we should reopen this and scope it towards the only warning I currently see?

Comment 16

[scottputterman]

sure. I'll reopen since we still get the js error. Since it doesn't appear to be
a blocker, I'm changing the severity and moving out.

Comment 17

[[e-mail] (gone - use [e-mail] instead)]

updating summary to reflect changes.

Comment 18

[Henrik Gemal]

*** This bug has been marked as a duplicate of 68525 ***

Comment 19

[[e-mail] (gone - use [e-mail] instead)]

verified dup.