1192533 - Allow running only one test via add_task.only() or skipping via add_task.skip()

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, enhancement)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

When debugging a test that has a lot of tasks added via add_task/add_test, I'd like to be able to run only one task. I would like to propose implementing add_task.only() and add_task.skip().

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8645363 [details] [diff] [review]
Fix - v1

Review of attachment 8645363 [details] [diff] [review]:
-----------------------------------------------------------------

This seems fine, this could use documentation somewhere. I guess ideally you'd be able to do this from the mach invocation without having to edit the test, but I don't think we have task names or anything that we could use to filter out at that level, do we?

Sorry for the long review delay. :-(

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Sorry for taking so long to push this, I wanted to at least look into how it could be done via mach. I'm going to go ahead with this patch (as soon as trees open) for now since in most cases when using only/skip you'll actually be working on a test and are modifying it anyway.

The task/test names are not available in python, but they are in head.js, so if the skip/only names are passed to xpcshell they could be filtered out at runtime. If this is done with mach, how would you want the invocation to look?


mach xpcshell-test mytest.js --task task1_in_file,task2_in_file --skip task1_in_file,task2_in_file

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5481fa5ce424

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5481fa5ce424