browser_urlbarSearchSuggestionsNotification.js is going to permafail when Gecko 42 merges to Aurora

VERIFIED FIXED in Firefox 42

Status

()

defect
--
critical
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: RyanVM, Assigned: mak)

Tracking

unspecified
Firefox 42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 verified)

Details

The uplift is Monday, so this is extremely urgent. This affects all platforms.

https://treeherder.mozilla.org/logviewer.html#?job_id=10247289&repo=try

20:33:55 INFO - 635 INFO checking window state
20:33:55 INFO - 636 INFO Entering test prepare
20:33:55 INFO - 637 INFO Waiting for engine to be added: searchSuggestionEngine.xml
20:33:55 INFO - 638 INFO Search engine added: searchSuggestionEngine.xml
20:33:55 INFO - 639 INFO Leaving test prepare
20:33:55 INFO - 640 INFO Entering test focus_allSuggestionsDisabled
20:33:55 INFO - 641 INFO TEST-PASS | browser/base/content/test/general/browser_urlbarSearchSuggestionsNotification.js | popup should be closed - true == true
20:33:55 INFO - 642 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_urlbarSearchSuggestionsNotification.js | Test timed out - expected PASS
20:33:55 INFO - 643 INFO TEST-PASS | browser/base/content/test/general/browser_urlbarSearchSuggestionsNotification.js | popup should be closed - true == true
20:33:55 INFO - MEMORY STAT | vsize 1298MB | residentFast 349MB | heapAllocated 148MB
20:33:55 INFO - 644 INFO TEST-OK | browser/base/content/test/general/browser_urlbarSearchSuggestionsNotification.js | took 45169ms
Flags: needinfo?(adw)
there are pending patches in fx-team that touch these tests and may fix the issue. it would be nice if fx-team could be merged and this checked again, we have patches there that must be merged before the aurora merge.
I can also land a test-only change that could help, I think the test should force the unified complete pref.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Flags: needinfo?(adw)
Yes, Ryan, bug 1192347 must land on m-c before the merge.  Are you planning on merging fx-team before the merge?  If not, we will need to land that bug directly on m-c.

However, this test needs to be updated to not run if unified complete is disabled.  I'll work on a patch for that.  But I don't understand why the test is timing out where it's timing out, according to that log.
Flags: needinfo?(ryanvm)
Oops, mid-air with Marco!  OK, I'll let you do this then. :-)
ok, we just need a merge now.
https://hg.mozilla.org/mozilla-central/rev/f78f4abd2f03
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Flags: needinfo?(ryanvm)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.