Closed
Bug 1192586
Opened 10 years ago
Closed 9 years ago
Suppress warnings in third-party library media/libav
Categories
(Core :: Web Audio, defect)
Core
Web Audio
Tracking
()
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
1.23 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
clang/gcc warnings:
media/libav/libavutil/avstring.c:57:16 [-Wincompatible-pointer-types-discards-qualifiers] returning 'const char *' from a function with result type 'char *' discards qualifiers
media/libav/libavutil/avstring.c:61:20 [-Wincompatible-pointer-types-discards-qualifiers] returning 'const char *' from a function with result type 'char *' discards qualifiers
media/libav/libavutil/avstring.c:71:16 [-Wincompatible-pointer-types-discards-qualifiers] returning 'const char *' from a function with result type 'char *' discards qualifiers
media/libav/libavutil/avstring.c:75:20 [-Wincompatible-pointer-types-discards-qualifiers] returning 'const char *' from a function with result type 'char *' discards qualifiers
media/libav/libavutil/dict.c:80:58 [-Wincompatible-pointer-types-discards-qualifiers] passing 'const char *' to parameter of type 'void *' discards qualifiers
media/libav/libavutil/dict.c:81:58 [-Wincompatible-pointer-types-discards-qualifiers] passing 'const char *' to parameter of type 'void *' discards qualifiers
media/libav/libavutil/dict.c:100:36 [-Wincompatible-pointer-types-discards-qualifiers] assigning to 'char *' from 'const char *' discards qualifiers
media/libav/libavutil/dict.c:104:38 [-Wincompatible-pointer-types-discards-qualifiers] assigning to 'char *' from 'const char *' discards qualifiers
media/libav/libavutil/eval.c:174:21 [-Wswitch] 16 enumeration values not handled in switch: 'e_value', 'e_const', 'e_func0'...
media/libav/libavutil/log.c:77:33 [-Wlogical-op-parentheses] '&&' within '||'
media/libav/libavutil/opt.c:49:13 [-Wswitch] 4 enumeration values not handled in switch: 'AV_OPT_TYPE_STRING', 'AV_OPT_TYPE_BINARY', 'AV_OPT_TYPE_DICT'...
media/libav/libavutil/opt.c:222:13 [-Wswitch] enumeration values 'AV_OPT_TYPE_DICT' and 'AV_OPT_TYPE_CONST' not handled in switch
media/libav/libavutil/opt.c:718:26 [-Wparentheses] using the result of an assignment as a condition without parentheses
media/libav/libavutil/opt.c:719:23 [-Wparentheses] using the result of an assignment as a condition without parentheses
media/libav/libavutil/opt.c:723:26 [-Wparentheses] using the result of an assignment as a condition without parentheses
media/libav/libavutil/opt.c:724:23 [-Wparentheses] using the result of an assignment as a condition without parentheses
media/libav/libavutil/opt.c:729:14 [-Wparentheses] using the result of an assignment as a condition without parentheses
media/libav/libavutil/random_seed.c:73:24 [-Wlogical-op-parentheses] '&&' within '||'
MSVC warnings:
media/libav/libavutil/avstring.c(57) : warning C4090: 'return' : different 'const' qualifiers
media/libav/libavutil/avstring.c(61) : warning C4090: 'return' : different 'const' qualifiers
media/libav/libavutil/avstring.c(71) : warning C4090: 'return' : different 'const' qualifiers
media/libav/libavutil/avstring.c(75) : warning C4090: 'return' : different 'const' qualifiers
media/libav/libavutil/avstring.c(105) : warning C4018: '>' : signed/unsigned mismatch
Attachment #8645405 -
Flags: review?(padenot)
Assignee | ||
Comment 1•10 years ago
|
||
oops. I forgot to remove some debug code.
Attachment #8645405 -
Attachment is obsolete: true
Attachment #8645405 -
Flags: review?(padenot)
Attachment #8645408 -
Flags: review?(padenot)
Updated•9 years ago
|
Attachment #8645408 -
Attachment is patch: true
Comment 2•9 years ago
|
||
Comment on attachment 8645408 [details] [diff] [review]
libav-suppress-warnings.patch
Review of attachment 8645408 [details] [diff] [review]:
-----------------------------------------------------------------
Same, looks like we'd want this, but let's ask qDot to make sure.
Attachment #8645408 -
Flags: review?(padenot) → review?(kyle)
Comment 3•9 years ago
|
||
Comment on attachment 8645408 [details] [diff] [review]
libav-suppress-warnings.patch
Review of attachment 8645408 [details] [diff] [review]:
-----------------------------------------------------------------
Yup, definitely want this. Thanks for cleaning it up!
Attachment #8645408 -
Flags: review?(kyle) → review+
Comment 5•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•