create deterministic header list ical.h

RESOLVED FIXED in 4.5

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: c.schoenert, Assigned: c.schoenert)

Tracking

Lightning 4.0.0.1
All
Linux

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0 Iceweasel/38.1.0
Build ID: 20150711212448

Steps to reproduce:

The Debian Reproducible Team (https://reproducible.debian.net/reproducible.html) catched a issue while building the Debian Icedove (Thunderbird) twice. The analyses shows up that the header ical.h could not be generated reproducible and the whole reproducible build of Icedove is failing on that.

Further information can be found on https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=794456




Actual results:

The created ical.h is changing with every build as the list of the headers is created randomly.




Expected results:

To create a deterministic list inside ical.h only few changes are needed. The current upstream version of libical add the needed changes long ago. If bug 1160990 is resolved no further action is needed. Otherwise look at the appended patch.
(Assignee)

Updated

4 years ago
OS: Unspecified → Linux
Hardware: Unspecified → All

Updated

4 years ago
Assignee: nobody → c.schoenert
Component: Build Config → Internal Components

Comment 1

4 years ago
Comment on attachment 8645420 [details] [diff] [review]
Generate-sorted-ical-header-list.patch

Setting r? for this, as updating libical in near future is probably unlikely.
Attachment #8645420 - Flags: review?(philipp)
Comment on attachment 8645420 [details] [diff] [review]
Generate-sorted-ical-header-list.patch

Review of attachment 8645420 [details] [diff] [review]:
-----------------------------------------------------------------

Fine with me, r=philipp I'd appreciate if we could give this a try run. Carsten, do you have hg access to take care? If not, please needinfo me or MakeMyDay.
Attachment #8645420 - Flags: review?(philipp) → review+
(Assignee)

Comment 3

4 years ago
Hello Philipp,

thanks for take care, I haven't access to hg and I'd like to not necessary handle this if possible. I'm not really firm with workflow you guys doing.
Flags: needinfo?(philipp)
Sure no problem. Here is the try push: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=cd6ab982f453
Note that tests will fail since they are failing on c-c, it is only important to see if there are new calendar test failures.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(philipp)

Comment 5

4 years ago
Patch with updated headers for checkin.
Attachment #8645420 - Attachment is obsolete: true
Attachment #8651372 - Flags: review+

Comment 6

4 years ago
Carsten, I hope you don't mind I have updated the patch headers for you. As the try log looked good, let's get this in.
Keywords: checkin-needed
(Assignee)

Comment 7

4 years ago
Go ahead! :-)
Thank for going further!

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.5
You need to log in before you can comment on or make changes to this bug.