Created attachment 8645420 [details] [diff] [review] Generate-sorted-ical-header-list.patch User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0 Iceweasel/38.1.0 Build ID: 20150711212448 Steps to reproduce: The Debian Reproducible Team (https://reproducible.debian.net/reproducible.html) catched a issue while building the Debian Icedove (Thunderbird) twice. The analyses shows up that the header ical.h could not be generated reproducible and the whole reproducible build of Icedove is failing on that. Further information can be found on https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=794456 Actual results: The created ical.h is changing with every build as the list of the headers is created randomly. Expected results: To create a deterministic list inside ical.h only few changes are needed. The current upstream version of libical add the needed changes long ago. If bug 1160990 is resolved no further action is needed. Otherwise look at the appended patch.
Comment on attachment 8645420 [details] [diff] [review] Generate-sorted-ical-header-list.patch Setting r? for this, as updating libical in near future is probably unlikely.
Comment on attachment 8645420 [details] [diff] [review] Generate-sorted-ical-header-list.patch Review of attachment 8645420 [details] [diff] [review]: ----------------------------------------------------------------- Fine with me, r=philipp I'd appreciate if we could give this a try run. Carsten, do you have hg access to take care? If not, please needinfo me or MakeMyDay.
Hello Philipp, thanks for take care, I haven't access to hg and I'd like to not necessary handle this if possible. I'm not really firm with workflow you guys doing.
Sure no problem. Here is the try push: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=cd6ab982f453 Note that tests will fail since they are failing on c-c, it is only important to see if there are new calendar test failures.
Created attachment 8651372 [details] [diff] [review] bug1192600-updatedHeaders.diff Patch with updated headers for checkin.
Carsten, I hope you don't mind I have updated the patch headers for you. As the try log looked good, let's get this in.
Go ahead! :-) Thank for going further!
https://hg.mozilla.org/comm-central/rev/3c1dbcbd0e112ce03e69da5d77da38b48ef83974 Bug 1192600 - create deterministic header list ical.h. r=philipp