1192606 - In the Applications in-content preferences, fix the Ctrl/Cmd+f and Ctrl/Cmd+k keys to focus the search box

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Steffen Wilberg]

In the in-content preferences, Applications pane, the keys to focus the Search box (Ctrl/Cmd+f and Ctrl/Cmd+k) are broken.
Accel+f now invokes the find bar instead, which is useless.

This is a regression from bug 1016300, which removed the oncommand attribute from the <key> elements. This doesn't work because of bug 371900.

The fix is to add |oncommand=";"| to the <key> elements.
Bug 978115 is on file to clean up these workarounds once bug 371900 is fixed.

Comment 1

[Steffen Wilberg]

Attachment: In the Applications in-content preferences, fix the Ctrl/Cmd+f and Ctrl/Cmd+k keys to focus the search box

Comment 2

[:Gijs (he/him)]

Comment on attachment 8645435 [details] [diff] [review]
In the Applications in-content preferences, fix the Ctrl/Cmd+f and Ctrl/Cmd+k keys to focus the search box

Review of attachment 8645435 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the super-clear explanation in comment #0. Wish all bugs came with descriptions that good.

Maybe leave a code comment (<!-- ... -->) before these two <key>s so we don't accidentally remove them again - something like "oncommand attributes are here because of bug 371900"?

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/aac05e8ce3ec

Comment 4

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #2)
> Maybe leave a code comment (<!-- ... -->) before these two <key>s so we
> don't accidentally remove them again - something like "oncommand attributes
> are here because of bug 371900"?

(In reply to Pulsebot from comment #3)
> https://hg.mozilla.org/integration/fx-team/rev/aac05e8ce3ec

I should really not land things without having tea in the morning.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/6509f5665152

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/aac05e8ce3ec
https://hg.mozilla.org/mozilla-central/rev/6509f5665152

Comment 7

[Khalid Syfullah Zaman [:khalid32]]

I have reproduced this bug on Nightly 42.0a1 (2015-08-09) on ubuntu 14.04 LTS, 32 bit!

The bug's fix is now verified on Latest Beta 43.0b3!

Build ID: 20151112144305
User Agent: Mozilla/5.0 (X11; Linux i686; rv:43.0) Gecko/20100101 Firefox/43.0

[testday-20151113]