1192629 - [yosemite][Instantbird] Simplified Chinese shows up in Traditional Chinese mode when saving an image.

Status: RESOLVED FIXED

(Instantbird Graveyard :: Other, defect)

Description

[Thomasy]

Attachment: The dialog affected by this bug

+++ This bug was initially created as a clone of Bug #1089363 +++

(From Bug 1089363 comment #47)
> Created attachment 8548547 [details]
> Thunderbird may be affected by this bug
> 
> I wonder if Thunderbird is affected by this bug?
> The attachment is the menu from Thunderbird. It shows the simplified Chinese.
> If it is affected, we need to open a new one.
https://bug1089363.bugzilla.mozilla.org/attachment.cgi?id=8548547

(From Bug 1089363 comment #0)
> Created attachment 8511644 [details]
> Screenshot https://bug1089363.bugzilla.mozilla.org/attachment.cgi?id=8511644
> 
> The language was in Traditional Chinese, but when the user look at an image,
> right-clicked and chose "Save as", some fields in the dialog were in
> Simplified Chinese.

Comment 1

[Thomasy]

Attachment: The menu item for the bug testing

Comment 2

[Thomasy]

Attachment: The menu item for the bug testing

Comment 3

[Thomasy]

Attachment: bug1192629_rev1.patch

Porting the patch according to bug 1089363.

Comment 4

[Thomasy]

Attachment: The dialog after applying the patch

Comment 5

[Patrick Cloke [:clokep]]

Comment on attachment 8645467 [details] [diff] [review]
bug1192629_rev1.patch

I *think* that this looks OK, but I don't feel completely comfortable with this section of our build system. I'm going to bounce this to Florian.

Comment 6

[Florian Quèze [:florian]]

Comment on attachment 8645467 [details] [diff] [review]
bug1192629_rev1.patch

Thanks for the patch. The content of the patch looks good, but I think we also need the installer/ changes from attachment 8645348 [details] [diff] [review] to replace this line: http://mxr.mozilla.org/comm-central/source/im/installer/package-manifest.in?rev=fad78598e6ac#45

Comment 7

[Thomasy]

Attachment: bug1192629_rev2.patch

Modification for the installer according to comment 6. Both en-US and zh-TW version are built on OS X 10.10.4 (with installer).

Comment 8

[aleth [:aleth]]

url:        https://hg.mozilla.org/comm-central/rev/6f267f62b5e3fbda779282d1b7167776b4b62b6c
changeset:  6f267f62b5e3fbda779282d1b7167776b4b62b6c
user:       Yu-Sian Liu <[e-mail]>
date:       Tue Aug 11 10:59:00 2015 +0200
description:
Bug 1192629 - Fix for zh-TW download image dialog. r=florian