Closed Bug 1192629 Opened 8 years ago Closed 8 years ago

[yosemite][Instantbird] Simplified Chinese shows up in Traditional Chinese mode when saving an image.

Categories

(Instantbird Graveyard :: Other, defect)

Product:
Instantbird Graveyard
Component:
Other
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Instantbird 43

People

(Reporter: thomas, Assigned: thomas)

References

Details

Attachments

(4 files, 2 obsolete files)

The dialog affected by this bug
89.05 KB, image/png
Details
The menu item for the bug testing
104.71 KB, image/png
Details
The dialog after applying the patch
90.91 KB, image/png
Details
bug1192629_rev2.patch
3.70 KB, patch
florian
: review+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #1089363 +++

(From Bug 1089363 comment #47)
> Created attachment 8548547 [details]
> Thunderbird may be affected by this bug
> 
> I wonder if Thunderbird is affected by this bug?
> The attachment is the menu from Thunderbird. It shows the simplified Chinese.
> If it is affected, we need to open a new one.
https://bug1089363.bugzilla.mozilla.org/attachment.cgi?id=8548547

(From Bug 1089363 comment #0)
> Created attachment 8511644 [details]
> Screenshot https://bug1089363.bugzilla.mozilla.org/attachment.cgi?id=8511644
> 
> The language was in Traditional Chinese, but when the user look at an image,
> right-clicked and chose "Save as", some fields in the dialog were in
> Simplified Chinese.
Attached image The menu item for the bug testing (obsolete) — 

    
    

    
  


  
Assignee: nobody → thomas

        Attachment #8645463 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        bug1192629_rev1.patch (obsolete)
        — 
          — Splinter Review
      

    


  
Porting the patch according to bug 1089363.

        Attachment #8645467 -
        Flags: review?(clokep)

    
    

    
  


  

    
  
Depends on: 1089363

    
    

    
  
Comment on attachment 8645467 [details] [diff] [review]
bug1192629_rev1.patch

I *think* that this looks OK, but I don't feel completely comfortable with this section of our build system. I'm going to bounce this to Florian.

        Attachment #8645467 -
        Flags: review?(florian)

        Attachment #8645467 -
        Flags: review?(clokep)

        Attachment #8645467 -
        Flags: feedback+

    
    

    
  
Comment on attachment 8645467 [details] [diff] [review]
bug1192629_rev1.patch

Thanks for the patch. The content of the patch looks good, but I think we also need the installer/ changes from attachment 8645348 [details] [diff] [review] to replace this line: http://mxr.mozilla.org/comm-central/source/im/installer/package-manifest.in?rev=fad78598e6ac#45

        Attachment #8645467 -
        Flags: review?(florian) → review-

    
    

    
  


  
Modification for the installer according to comment 6. Both en-US and zh-TW version are built on OS X 10.10.4 (with installer).

        Attachment #8645467 -
        Attachment is obsolete: true

        Attachment #8646488 -
        Flags: review?(florian)

        Attachment #8646488 -
        Flags: review?(florian) → review+

    
    

    
  
url:        https://hg.mozilla.org/comm-central/rev/6f267f62b5e3fbda779282d1b7167776b4b62b6c
changeset:  6f267f62b5e3fbda779282d1b7167776b4b62b6c
user:       Yu-Sian Liu <thomas@thomasy.tw>
date:       Tue Aug 11 10:59:00 2015 +0200
description:
Bug 1192629 - Fix for zh-TW download image dialog. r=florian

    
  
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 43

          You need to log in
          before you can comment on or make changes to this bug.