Closed Bug 1192689 Opened 4 years ago Closed 4 years ago

none-ion compile errors: invalid static_cast from LNode

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox42 --- fixed
firefox43 --- fixed

People

(Reporter: stevensn, Assigned: stevensn)

Details

Attachments

(1 file, 1 obsolete file)

When building with the the none jit backend I get the following compile error (among many other similar ones)

src/js/src/jit/LIR.h: In member function \u2018const js::jit::LAsmJSUInt32ToFloat32* js::jit::LNode::toAsmJSUInt32ToFloat32() const\u2019:
src/js/src/jit/LIR.h:1854:80334: error: invalid static_cast from type \u2018const js::jit::LNode* const\u2019 to type \u2018const js::jit::LAsmJSUInt32ToFloat32*\u2019
     LIR_OPCODE_LIST(LIROP)
                                    

This patch adds some missing operator classes to LIR-none
Attached patch add-LIR-none-instructions.diff (obsolete) — Splinter Review
Attachment #8645530 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8645530 [details] [diff] [review]
add-LIR-none-instructions.diff

Review of attachment 8645530 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks :)

::: js/src/jit/none/LIR-none.h
@@ +52,5 @@
> +class LUnbox : public LInstructionHelper<1, 2, 0>
> +{
> +  public:
> +
> +    MUnbox* mir() const { MOZ_CRASH(); }    

nit: remove trailing white spaces.
Attachment #8645530 - Flags: review?(nicolas.b.pierron) → review+
Attachment #8645530 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/494bb118f05c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Comment on attachment 8646735 [details] [diff] [review]
add-LIR-none-instructions.diff

Approval Request Comment
[Feature/regressing bug #]: not known which changed started to make these methods required for the none-backend
[User impact if declined]: non-ion builds (ie some tier3 platforms) won't build
[Describe test coverage new/current, TreeHerder]: NPOTB
[Risks and why]:  Low NPOTB for tier1
[String/UUID change made/needed]: no
Attachment #8646735 - Flags: approval-mozilla-aurora?
Comment on attachment 8646735 [details] [diff] [review]
add-LIR-none-instructions.diff

The lack of comment in this patch is surprising to me but if Nicolas r+ it, why not...
Taking it in aurora to help the support on other archs.
Attachment #8646735 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.