1192709 - [Contacts]The "Anniversary" option will be removed.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Lance（leave from Mozilla）]

Attachment: logcat_2355.txt

[1.Description]:
[Aries KK v2.5][Flame KK v2.5][Contacts]When you tap the "Add Date" for three times, the "Anniversary" option will be removed.
Found time:23:55
See attachment:Aries_2.5.3gp and logcat_2355.txt

[2.Testing Steps]: 
1.Launch Contacts.
2.Tap create contact to enter the create contact page.
3.Tap the "Add Date" icon twice.
4.Tap the "Add Date" icon again.

[3.Expected Result]: 
4.The "Anniversary" option should not be removed.

[4.Actual Result]: 
4.The "Anniversary" option will be removed.

[5.Reproduction build]: 
Device: Aries KK 2.5(Affected)
Build ID               20150806203229
Gaia Revision          7f387f859d48f9ad0761637c78447dc524747738
Gaia Date              2015-08-06 15:21:13
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/03e3d77d1b6b
Gecko Version          42.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150806.195600
Firmware Date          Thu Aug  6 19:56:08 UTC 2015
Bootloader             s1

Device: Flame KK 2.2(Unaffected)
9Build ID               20150809032505
Gaia Revision          102f1299e9eafe3760e1deb44d556b5c4f36b5af
Gaia Date              2015-08-06 20:46:56
Gecko Revision         https://hg.mozilla.org/releases/mozilla-

b2g37_v2_2/rev/da29b5af4232
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150809.065320
Firmware Date          Sun Aug  9 06:53:31 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK 2.5(Affected)
Build ID               20150809150206
Gaia Revision          3e5271663e7ef26290c29a45d2e42c0d3c20fe04
Gaia Date              2015-08-08 21:13:59
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/fd69d51a4068
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150809.182413
Firmware Date          Sun Aug  9 18:24:24 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
occasionally Recurrence,4/5

[7.TCID]: 
Free Test

Comment 1

[Lance（leave from Mozilla）]

Attachment: Aries_2.5.3gp

Comment 2

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: Functional regression.

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comms triage: Functional regression. Let's bring back what we had in 2.2.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Just checked 2.2 and we have exactly the same behavior.

If you click several times in 'add data' when it's disabled it will remove one of the dates.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Ok,

I figure out what's going on here. When you have the button for delete a field, that button is taking not just the image but all the area within the container.

So when you click on delete, if it happens that you touch the date field (on the same area than the add) it's also activating the delete of that field.

Not a regression of 2.5, but we suffer more from this in aries, what I did is add a margin in the bottom to avoid tapping delete when we want to tap on the add button.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] arcturus:bug-1192709 > mozilla-b2g:master

Comment 7

[Fernando Campo (:fcampo)]

Comment on attachment 8647579 [details] [review]
[gaia] arcturus:bug-1192709 > mozilla-b2g:master

code looks good, and margin seems enough to not let me repro the issue.
just a reminder that I'm not a peer.

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

> 
> code looks good, and margin seems enough to not let me repro the issue.
> just a reminder that I'm not a peer.

I know, but all of them are on holidays, and you know this code well enough lately ;)

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/4b09b8824e3c68d8f5208a53f9ae3a8917dc9560

Comment 10

[Jessica]

Attachment: verified_Aries KK v2.5.3gp

According to the STR of Comment 0, this bug has been verified as pass on latest Nightly Flame KK v2.5 and Aries KK v2.5.

Actual results: The "Anniversary" option is not removed, and the “+” button is not available.
See attachment: verified_Aries KK v2.5.3gp
Reproduce rate: 0/6


Device: Flame KK v2.5 (Pass)
Build ID               20150816150205
Gaia Revision          47c91ffe7f500ca1aaa60de0aabf4d2429120733
Gaia Date              2015-08-14 18:55:02
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0876695d1abdeb363a780bda8b6cc84f20ba51c9
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150816.182145
Firmware Date          Sun Aug 16 18:21:56 EDT 2015
Bootloader             L1TC000118D0

Device: Aries KK v2.5 (Pass)
Build ID               20150816151853
Gaia Revision          47c91ffe7f500ca1aaa60de0aabf4d2429120733
Gaia Date              2015-08-14 18:55:02
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0876695d1abdeb363a780bda8b6cc84f20ba51c9
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150816.144248
Firmware Date          Sun Aug 16 14:42:55 UTC 2015
Bootloader             s1