1192726 - Convert forward locked radio controls to use web components

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kevin Grandon :kgrandon]

This is the last usage of the pack-radio controls, let's convert them to use web components.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1192726_fl_gaia_radio > mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8645594 [details] [review]
[gaia] KevinGrandon:bug_1192726_fl_gaia_radio > mozilla-b2g:master

David - could you review this when you have a chance? Thanks!

Comment 3

[Kevin Grandon :kgrandon]

Review ping?

Comment 4

[David Flanagan [:djf]]

Attachment: locked ringtones pick view without this patch

Comment 5

[David Flanagan [:djf]]

Attachment: locked ringtones pick view with this patch

Comment 6

[David Flanagan [:djf]]

Comment on attachment 8645594 [details] [review]
[gaia] KevinGrandon:bug_1192726_fl_gaia_radio > mozilla-b2g:master

The FL app is basically unsupported, so I don't think we need to be really picky about how it looks. But this patch changes the appearance in a pretty bad way, so I'm giving r-. See the attached screenshots. (Those screenshots are from my Aries device)

Kevin: first of all, I'm sorry it took this long to review. I've been really busy myself, but don't know if anyone else knows this code well enough to test or review your patch.

Also: If you do not know how to test the patch, you can visit http://djf.net/t.html to find links to test forward-locked audio files. The first link on that page is broken, but the second and third links take you to pages with other links. You should be able to find two or three files there that you can download and install as ringtones.  Then, in the settings app, when you go to change your ringtone, you will be able to select "Purchased Media", and that will show you the downloaded ringtones and the radio buttons.

Comment 7

[Kevin Grandon :kgrandon]

Thanks for the review! Sorry about the UI issue - I definitely tested this and don't recall this problem, but maybe something changed upstream. I'll take a look and get this fixed, thanks.

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8645594 [details] [review]
[gaia] KevinGrandon:bug_1192726_fl_gaia_radio > mozilla-b2g:master

Hi David - 

Sorry about the UI issue - I've fixed this, so please take a look when you can.

While testing this feature I also noticed a few functionality bugs (settings app doesn't seem to *actually* save them). You said this app was unsupported, so let me know if I should bother filing these bugs are not.

These bugs also manifest on master, so I think we can go ahead and land this patch when ready. Thanks!

Comment 9

[David Flanagan [:djf]]

Comment on attachment 8645594 [details] [review]
[gaia] KevinGrandon:bug_1192726_fl_gaia_radio > mozilla-b2g:master

Looks good now, Kevin. Thanks for doing this.

During the last round of testing I found the same bug you did and filed 1200395. Jim is on it.

Comment 10

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/8cc412208a2fd1463dbed829984b53c287ae0a95