Closed
Bug 1192738
Opened 10 years ago
Closed 10 years ago
Drop the old aspect ratio calculation code now that the media layout refactors have been completed
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(firefox43 fixed)
People
(Reporter: standard8, Assigned: standard8)
Details
(Whiteboard: [tech-debt])
Attachments
(1 file)
Now that the media layout refactors have completed, we can drop the old code we were using for calculations.
We may want some of it again in future, but we've always got history for that if we do.
Flags: qe-verify-
Flags: firefox-backlog+
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8645611 -
Flags: review?(andrei.br92)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8645611 [details] [diff] [review]
Drop the old aspect ratio calculation code now that Loop's media layout refactors have been completed.
Review of attachment 8645611 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, ship it!
Our test coverage % went up with this code removal, that should say something ;)
Attachment #8645611 -
Flags: review?(andrei.br92) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•