Closed Bug 1192738 Opened 7 years ago Closed 7 years ago

Drop the old aspect ratio calculation code now that the media layout refactors have been completed

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
normal
Points:
1

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Iteration:
42.3 - Aug 10
Tracking Status
firefox43 --- fixed
backlog tech-debt

People

(Reporter: standard8, Assigned: standard8)

Details

(Whiteboard: [tech-debt])

Attachments

(1 file)

Now that the media layout refactors have completed, we can drop the old code we were using for calculations.

We may want some of it again in future, but we've always got history for that if we do.
Flags: qe-verify-
Flags: firefox-backlog+
Comment on attachment 8645611 [details] [diff] [review]
Drop the old aspect ratio calculation code now that Loop's media layout refactors have been completed.

Review of attachment 8645611 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, ship it!

Our test coverage % went up with this code removal, that should say something ;)
Attachment #8645611 - Flags: review?(andrei.br92) → review+
https://hg.mozilla.org/mozilla-central/rev/2e61c9725c74
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.