1192764 - Active waffle switches have been inadvertently flipped off on prod

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Alex Gibson [:agibson]]

It seems like Bug 1191923 was not an isolated case.

We just has Bug 1192753 reported for the Firefox OS TV page. But it looks like other active waffle switches have been somehow turned off also:

For example:

https://www-dev.allizom.org/en-US/firefox/hello/
https://www.mozilla.org/en-US/firefox/hello/

Note how the second Firefox Hello feature on dev is "Share and share alike", yet on prod it has reverted to the old "Invite anyone, anywhere".

I'm guessing there may be more cases where an active switch has been turned off. Can we do an active audit of which switches are currently in existence and their current state?

We should probably also remove any may no longer required.

Comment 1

[Alex Gibson [:agibson]]

Switches that appear to be turned off:

'dev-edition-spring-campaign'
'android-spring-updates'
'hello-screen-sharing'
'patriot-act-home-promo'

As far as I know all of these should be switched on.

There is also 'mwc-2015-preview', but this page is being redirected to /firefox/partners/ now anyway. We can probably just remove this particular waffle switch.

I haven't gone through the Optimizely switches, as I'm not yet sure what should be active for those.

Comment 2

[Alex Gibson [:agibson]]

Attachment: GitHub pull request

Opened a PR to remove waffle switches that are no longer needed.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/a4f1fe2978cc6aae9d4beca664477ff4f8bd3daf
[bug 1192764] Remove waffle switches which are no longer needed

https://github.com/mozilla/bedrock/commit/7c15de556aa7550c509db58d5a7ac06ea593c9db
Merge pull request #3197 from alexgibson/remove-old-waffle-switches

[bug 1192764] Remove waffle switches which are no longer needed

Comment 4

[Josh Mize [:jgmize]]

Commits from comment #3 pushed to production. Current waffle switch status in prod:

>>> for s in Switch.objects.order_by('name'): print s.name, 'on' if s.active else 'off'

android-spring-updates off
contribute-signup-optimizely on
dev-edition-spring-campaign off
firefox-android-optimizely off
firefox-desktop-optimizely off
firefox-firstrun-optimizely off
firefox-hello-optimizely off
firefox-installer-help-optimizely off
firefox-new-optimizely on
firefox-os-index-2015 off
firefox-os-tv off
firefox-personal-optimizely off
firefox-products-optimizely off
firefox-releasenotes-optimizely off
firefox-whatsnew-optimizely off
firefox_pocket off
fundraiser-home-takeover off
fx40-firstrun off
fxos-devices-panasonic-tv off
hello-screen-sharing off
lg-fx0-available off
mozorg-home-neutrality-promo off
mozorg-home-optimizely off
mozorg-home-privacy-promo off
mozorg-home-privacy-promo-jan28 off
mozorg-mission-optimizely off
mwc-2015-logos off
mwc-2015-preview off
patriot-act-home-promo off
plugincheck-optimizely off
pocket-active on

Current waffle switches referred to in code:

$ ag waffle.switch 

bedrock/mozorg/templates/mozorg/mission.html
29:  {% if waffle.switch('mozorg-mission-optimizely') %}

bedrock/mozorg/templates/mozorg/plugincheck.html
37:  {% if waffle.switch('plugincheck-optimizely') %}

bedrock/mozorg/templates/mozorg/home/home.html
43:  {% if waffle.switch('mozorg-home-optimizely') %}

bedrock/mozorg/templates/mozorg/contribute/contribute-tasks.html
12:  {% if LANG == 'en-US' and waffle.switch('contribute-signup-optimizely') %}

bedrock/mozorg/templates/mozorg/contribute/contribute-tasks-survey.html
10:  {% if LANG == 'en-US' and waffle.switch('contribute-signup-optimizely') %}

bedrock/mozorg/templates/mozorg/contribute/signup.html
14:  {% if LANG == 'en-US' and waffle.switch('contribute-signup-optimizely') %}

bedrock/firefox/templates/firefox/win10-welcome.html
23:  {% if waffle.switch('firefox-win10-optimizely') %}

bedrock/firefox/templates/firefox/australis/fx40/firstrun.html
31:  {% if waffle.switch('firefox-firstrun-optimizely') %}

bedrock/firefox/templates/firefox/includes/download-button.html
67:            {% elif plat.os == 'ios' and waffle.switch('ios-active') %}

bedrock/firefox/templates/firefox/australis/fx36/firstrun-tour.html
20:  {% if waffle.switch('firefox-firstrun-optimizely') %}

bedrock/firefox/templates/firefox/personal.html
14:  {% if waffle.switch('firefox-personal-optimizely') %}

bedrock/firefox/templates/firefox/australis/fx38_0_5/firstrun.html
31:  {% if waffle.switch('firefox-firstrun-optimizely') %}

bedrock/firefox/templates/firefox/desktop/index.html
19:  {% if waffle.switch('firefox-desktop-optimizely') %}

bedrock/firefox/templates/firefox/releases/release-notes.html
18:  {% if waffle.switch('firefox-releasenotes-optimizely') %}

bedrock/firefox/templates/firefox/installer-help.html
13:  {% if waffle.switch('firefox-installer-help-optimizely') %}

bedrock/firefox/templates/firefox/new.html
47:  {% if waffle.switch('firefox-new-optimizely') %}

bedrock/firefox/templates/firefox/whatsnew-fx37.html
25:  {% if waffle.switch('firefox-whatsnew-optimizely') %}

bedrock/firefox/templates/firefox/hello/start-40.0.html
22:  {% if waffle.switch('firefox-hello-ftu-optimizely') %}

bedrock/firefox/templates/firefox/family/index.html
23:  {% if waffle.switch('firefox-products-optimizely') %}

bedrock/firefox/templates/firefox/hello/index.html
30:  {% if waffle.switch('firefox-hello-optimizely') %}

bedrock/firefox/templates/firefox/android/index.html
18:  {% if waffle.switch('firefox-android-optimizely') %}

bedrock/firefox/templates/firefox/whatsnew_38/whatsnew-base.html
25:  {% if waffle.switch('firefox-whatsnew-optimizely') %}

bedrock/firefox/views.py
393:    if (waffle.switch_is_active('fx40-firstrun')):


Verified optimizely switches match https://wiki.mozilla.org/Mozilla.org/Optimizely and non-optimizely switches, fx40-firstrun and ios-active, are intentionally off.