1192769 - Can't see visible action when I click "Change Search Settings" if about:preferences#search is already opened

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P4)

Description

[arni2033]

STR:
1.   Open about:preferences#search
2.A) Click dropmarker in location bar
2.B) Click dropmarker in search bar
3.   Click button "Change Search Settings"

RESULT:       Nothing happens
Expectations: Drop-down list should hide to show preferences page

Comment 1

[Marco Bonardo [:mak]]

not blocking unified complete since this is not even part of it, it's related to one-click searches UI (bug 1180944).
I agree the dropdown should be closed regardless.

Comment 2

[Florian Quèze [:florian]]

Attachment: Patch

Comment 3

[:Gijs (out for now; he/him)]

Comment on attachment 8661203 [details] [diff] [review]
Patch

Review of attachment 8661203 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e5658e0e9c6d

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e5658e0e9c6d

Comment 6

[arni2033]

Er... I actually expected something better than that, e.g. some transitioning highlight indicating that the panel not only disappeared (may be perceived as a bug), but the user is already on the right page, and can actually start changing search settings.

Well, anyway, I'm not going to file (almost) the same report again; plus that feature would require some additional designer's work.

Comment 7

[Nazir Ahmed Sabbir [:NaSb]]

Reproduced this bug by following comment 0 with Firefox Nightly 42.0a1 (2015-08-10); 
(Build ID: 20150810030205) on Linux, 64 Bit

This Bug is now verified as fixed on Latest Firefox Beta 43.0b7

Build ID 	20151126120800
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0

Comment 8

[Rakibul Islam Ratul]

Reproduced this bug by following comment 0 with Firefox Nightly 42.0a1 (2015-08-10); 
(Build ID: 20150810030205; User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:42.0) Gecko/20100101 Firefox/42.0) on Windows 8.1, 64 Bit

This Bug is now verified as fixed on Latest Firefox Beta 43.0b7

Build ID 	20151126120800
User Agent 	Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:43.0) Gecko/20100101 Firefox/43.0


As per comment 7, changing the status as verified fixed.