Closed Bug 1192769 Opened 6 years ago Closed 5 years ago

Can't see visible action when I click "Change Search Settings" if about:preferences#search is already opened

Categories

(Firefox :: Address Bar, defect, P4)

defect

Tracking

()

VERIFIED FIXED
Firefox 43
Tracking Status
firefox43 --- verified

People

(Reporter: arni2033, Assigned: florian)

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

STR:
1.   Open about:preferences#search
2.A) Click dropmarker in location bar
2.B) Click dropmarker in search bar
3.   Click button "Change Search Settings"

RESULT:       Nothing happens
Expectations: Drop-down list should hide to show preferences page
Summary: Can't see visible action when I click "Change Search Settings" → Can't see visible action when I click "Change Search Settings" if about:preferences#search is opened
Component: Preferences → Location Bar
Summary: Can't see visible action when I click "Change Search Settings" if about:preferences#search is opened → Can't see visible action when I click "Change Search Settings" if about:preferences#search is already opened
not blocking unified complete since this is not even part of it, it's related to one-click searches UI (bug 1180944).
I agree the dropdown should be closed regardless.
Priority: -- → P3
Whiteboard: [fxsearch]
No longer blocks: UnifiedComplete
Rank: 45
Priority: P3 → P4
Attached patch PatchSplinter Review
Assignee: nobody → florian
Attachment #8661203 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8661203 [details] [diff] [review]
Patch

Review of attachment 8661203 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8661203 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/e5658e0e9c6d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Er... I actually expected something better than that, e.g. some transitioning highlight indicating that the panel not only disappeared (may be perceived as a bug), but the user is already on the right page, and can actually start changing search settings.

Well, anyway, I'm not going to file (almost) the same report again; plus that feature would require some additional designer's work.
Reproduced this bug by following comment 0 with Firefox Nightly 42.0a1 (2015-08-10); 
(Build ID: 20150810030205) on Linux, 64 Bit

This Bug is now verified as fixed on Latest Firefox Beta 43.0b7

Build ID 	20151126120800
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0
QA Whiteboard: [testday-20151127]
Reproduced this bug by following comment 0 with Firefox Nightly 42.0a1 (2015-08-10); 
(Build ID: 20150810030205; User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:42.0) Gecko/20100101 Firefox/42.0) on Windows 8.1, 64 Bit

This Bug is now verified as fixed on Latest Firefox Beta 43.0b7

Build ID 	20151126120800
User Agent 	Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:43.0) Gecko/20100101 Firefox/43.0


As per comment 7, changing the status as verified fixed.
Status: RESOLVED → VERIFIED
Has STR: --- → yes
You need to log in before you can comment on or make changes to this bug.