Closed Bug 1192774 Opened 4 years ago Closed 4 years ago

Rename nsOuterWindowProxy::GetWindow to GetOuterWindow and add an assertion.

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
Even though I should know better, I assumed `GetWindow` would return an inner window. I think this would be helpful.

I also renamed some local variables from `global` to `outerWindow` for clarity.
Attachment #8645660 - Flags: review?(khuey)
Comment on attachment 8645660 [details] [diff] [review]
Patch v1

Review of attachment 8645660 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, with a real commit message
Attachment #8645660 - Flags: review?(khuey) → review+
https://hg.mozilla.org/mozilla-central/rev/3cab41c41019
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.