1192826 - Sync StorageClient User-Agent setting needs to occur on the UI thread

Status: RESOLVED FIXED

(Firefox for iOS :: Sync, defect)

Description

[Stephan Leroux [:sleroux]]

Attachment: SendToCrash.crash

STR:

1. Visit mozilla.org in Safari
2. Make sure Send To is enabled as share option
3. Tap Send To

Expected: 

Send to modal should appear with synced devices

Actual:

Modal crashes and does not appear

----

Looks like we're crashing because UIWebView is being created in a background thread.

Comment 1

[Richard Newman [:rnewman]]

Regression from Bug 1164140.

Comment 2

[Richard Newman [:rnewman]]

Disabled in commit 72b1a19. Let's leave this open for a proper fix.

Comment 3

[Richard Newman [:rnewman]]

Presumably this only crashes if we've never computed the U-A string…

Comment 4

[Richard Newman [:rnewman]]

I think this might need to be morphed slightly.

* We should use an ephemeral session in the manager, not the default one -- we don't need to record anything to disk.

* FxA and Token Server should set UAs, too, and also use ephemeral managers.

* The UA actually -should not- be the same as the one the browser uses. It should be something like "Firefox-iOS-Sync/28 (Nightly)" to match Android.

Comment 5

[Richard Newman [:rnewman]]

Attachment: Pull req.

This establishes a manager for each client, setting the UAs to fixed strings. All managers are using an ephemeral configuration, which means nothing is persisted to disk.

General consensus is that manager cleanup happens automatically on dealloc, which is why you don't see us doing that anywhere.

There's also some version number and general UA cleanup.

Comment 6

[Stephan Leroux [:sleroux]]

Comment on attachment 8645915 [details] [review]
Pull req.

Looks good with some of the comments addressed!

Comment 7

[Stephan Leroux [:sleroux]]

Merged