Closed Bug 1192831 Opened 5 years ago Closed 5 years ago

Remove PlayPreview API

Categories

(Core :: Plug-ins, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: yury, Assigned: yury)

References

Details

Attachments

(1 file, 1 obsolete file)

This will make bug 558184 smaller. We arealready changing two its known users (PDF Viewer and Shumway) to not use the API, so we can remove the API itself.
Attached patch Remove PlayPreview API (obsolete) — Splinter Review
Based on the Part 5 patch from bug 1186577 (or bug 558184): rebased and removal another PlayPreview test included.
Attachment #8649556 - Flags: review?(bugs)
Comment on attachment 8649556 [details] [diff] [review]
Remove PlayPreview API

Review of attachment 8649556 [details] [diff] [review]:
-----------------------------------------------------------------

r=me based on these patches basically using identical code used in jsplugins to remove this API
Attachment #8649556 - Flags: review?(bugs) → review+
Leaving a NI? for PeterV to look at bug 1186577 again after this lands.
Flags: needinfo?(peterv)
(Updated uuid in nsPluginsHost.idl)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c086584b222
Attachment #8649556 - Attachment is obsolete: true
Keywords: checkin-needed
webidl changes need DOM peer review
Keywords: checkin-needed
Keywords: checkin-needed
Backed out for suspicion of being the cause of the big spike in bug 1178709 on Windows 8. I'll re-land if that turns out to not be the case.
https://hg.mozilla.org/integration/mozilla-inbound/rev/23649438b3bb
Confirmed fixed by backout.
Blocks: 1148827
Depends on: 1178709
https://hg.mozilla.org/mozilla-central/rev/073c612673cf
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Duplicate of this bug: 1221692
Flags: needinfo?(peterv)
You need to log in before you can comment on or make changes to this bug.