Closed Bug 1192917 Opened 6 years ago Closed 6 years ago

Update 'unknown' steps and jobs to a more informative UX

Categories

(Tree Management :: Treeherder, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jfrench, Assigned: jfrench)

References

Details

Attachments

(2 files)

Currently unknown jobs in Treeherder are black, and unknown steps in Logviewer have no color.

So lets update them both to a consistent color, and a more intuitive one than black. I posed a bootstrap-esque 'warning' yellow to Ed in channel and it seemed well received.

Initial proposed:
color: 138, 109, 59
background: 252, 248, 227
border-color: 251, 216, 144

...and perhaps some extra "(unknown step)" text adjacent to the step name in Logviewer for visibility and a11y.

Here is an example of an unknown and unstyled step, "Running tests"
https://treeherder.allizom.org/logviewer.html#?job_id=9386596&repo=mozilla-inbound
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
See bootstrap also for the reference point on the proposed appearance
http://getbootstrap.com/components/#alerts
Attached image unknownStepLogviewer
This is what I'd like to go with for an unknown logviewer step, to raise visibility both when the step is selected (per screen grab), and when it isn't.
Attached file PR 859
Please see above PR for status and review.
Attachment #8646438 - Flags: review?(cdawson)
Ed, do you have any preferences for a color for coalesced? (currently a mustard-ish yellow). Since we're planning to use a different bootstrap yellow here for unknown.

If not I'll try to find a suitable hue :)
Flags: needinfo?(emorley)
Oh, and you can check/compare if needed in the PR conversation.
Happy for you to pick - you have a good eye for this :-)
Flags: needinfo?(emorley)
Summary: Update 'unknown' steps and jobs to a more informative color → Update 'unknown' steps and jobs to a more informative UX
Comment on attachment 8646438 [details] [review]
PR 859

Clearing the review.  Things look good code-wise.  But it'll need to be rebased and I think there's a color decision to make on coalesced jobs.  Please reassign when you've got it ready.  Looks great!
Attachment #8646438 - Flags: review?(cdawson)
Comment on attachment 8646438 [details] [review]
PR 859

Ok I think I'm ready for another review. That was a bit of rebasing over the job counts work :)

:camd if you want to locally check the yellow unknown and light blue coalesced buttons you can switch say running btn-dkgray with btn-yellow or btn-ltblue in services/providers.js. Since both are not that common for testing against counts or large numbers of jobs.

You can also look at coalesced here in my gh-pages at the moment

http://tojonmz.github.io/treeherder/ui/#/jobs?repo=mozilla-inbound&revision=823aa80c5ffa&filter-resultStatus=success&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=coalesced
Attachment #8646438 - Flags: review?(cdawson)
Comment on attachment 8646438 [details] [review]
PR 859

More rebasing work to do so removing the r?. The Logviewer contents need tweaking.
Attachment #8646438 - Flags: review?(cdawson)
Attachment #8646438 - Flags: review?(cdawson)
Comment on attachment 8646438 [details] [review]
PR 859

Looks great!  Thanks for doing this!
Attachment #8646438 - Flags: review?(cdawson) → review+
Marking fixed per above merge.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
A push has been made to stage with a grunt build, so we can see what this looks like on stage now:
https://treeherder.allizom.org/logviewer.html#?job_id=10246382&repo=mozilla-inbound

I think since a result of "unknown" is expected for the placeholder steps we create for taskcluster jobs, the warning icons/text on each unknown step appears on all taskcluster jobs. Perhaps we should remove the warning icon/text and just keep the other style changes - otherwise it looks like something has broken, when in fact it's expected?
s/I think since/Since/

Also, this needn't block the next prod push, let's just tweak this in another bug at some point :-)
(In reply to Ed Morley [:emorley] from comment #13)
> I think since a result of "unknown" is expected for the placeholder steps we
> create for taskcluster jobs, the warning icons/text on each unknown step
> appears on all taskcluster jobs. Perhaps we should remove the warning
> icon/text and just keep the other style changes - otherwise it looks like
> something has broken, when in fact it's expected?

Ya I noticed this change while this PR was open and during which time that Taskcluster change landed :) Prior to it we had some legitimate cases where some were 'unknown' and others were ''. I thought all those new unknown Taskcluster steps legitimately needed a yellow display state, but I'll remove the step warnings in a separate bug/PR.
Now bug 1199659.
Logviewer unknown steps and the Coalesced job button change verified fixed on production. Unknown job buttons were not verified, as we don't have a filter for them at present and none were immediately visible.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.