Closed Bug 1192942 Opened 11 years ago Closed 11 years ago

DIsallow IOErrors on failed thumbnail creation

Categories

(Webtools Graveyard :: Air Mozilla, defect)

Product:
Webtools Graveyard
Component:
Air Mozilla
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox43 affected)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox43 --- affected

People

(Reporter: peterbe, Assigned: peterbe)

Details

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla/airmozilla/pull/430
46 bytes, text/x-github-pull-request
Details | Review
We currently allow IOErrors be swallowed [0] when we get IOErrors upon generating thumbnails when viewing events. This was originally done because we allowed this to happen during test runs where we didn't want to have to mess with uploading a fully working file first. [0] https://github.com/mozilla/airmozilla/blob/b91a29fae0bb48acdebd03f6d30130d0340df285/airmozilla/main/helpers.py#L108-L109
Assignee: nobody → peterbe
Commits pushed to master at https://github.com/mozilla/airmozilla https://github.com/mozilla/airmozilla/commit/ba55b8f4e611c5170573ea53d166089a5a9597dd fixes bug 1192942 - disallow IOErrors swallowed in thumbnail() https://github.com/mozilla/airmozilla/commit/1c32d83a469940e74f1452b794197eba82ba5183 Merge pull request #430 from peterbe/dont-accept-ioerrors-on-thumbnail-creation fixes bug 1192942 - disallow IOErrors swallowed in thumbnail()
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: