119295 - [mach] Mach-O Lacks a Custom Icon

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Zach Lipton [:zach]]

Mach-O has no custom icon and just displays the generic app icon. Patch 
is coming.

Comment 1

[Zach Lipton [:zach]]

Attachment: Patch to fix. Requires icns file (also attached)

Comment 2

[Zach Lipton [:zach]]

Attachment: mach.incs file to go in mozilla/xpfe/bootstrap/macbuild

Comment 3

[timeless]

Comment on attachment 64378 [details] [diff] [review]
Patch to fix. Requires icns file (also attached)

Welcome to y2002 should you update your (c) info?

Comment 4

[Zach Lipton [:zach]]

Patch is ready for review. Adding [mach] code. I fixed some of the plist 
metadata while I was in there to more closely match the CFM build.

Comment 5

[Zach Lipton [:zach]]

Attachment: New patch with 2002 copyright date

Comment 6

[Mike Pinkerton (not reading bugmail)]

r=pink

Comment 7

[Zach Lipton [:zach]]

Comment on attachment 64380 [details] [diff] [review]
New patch with 2002 copyright date

adding has review as per pink's comment

Comment 8

[Zach Lipton [:zach]]

Attachment: Same patch without the mac binary header so it looks pretty and applies

Comment 9

[Zach Lipton [:zach]]

Comment on attachment 64388 [details] [diff] [review]
Same patch without the mac binary header so it looks pretty and applies

rolling pink's review into here

Comment 10

[Zach Lipton [:zach]]

Attachment: grr, fix both 2001's

Comment 11

[Simon Fraser [no longer active]]

Looks OK. Does the Info.plst match the Carbon one as much as possible?

xpfe/bootstrap/macbuild/Contents is also evil and should go away (need to build 
it via script), because the OS 9 Finder treats it like a package (see bug 
108036).

Otherwise, sr=sfraser on the changes.

Comment 12

[Zach Lipton [:zach]]

Fix checked in