1192951 - Remove aero from the tree. Part 9 (primaryToolbar)

Status: RESOLVED FIXED

Description

[Richard Marti (:Paenglab)]

Remove primaryToolbar-aero.css.

Comment 1

[Richard Marti (:Paenglab)]

Created attachment 8645864 [details] [diff] [review]
No-primaryToolbar-aero.patch

This is only a copy from -aero to normal and adding the media queries with moving the the doubled rules to common rules.

Comment 2

[Philipp Kewisch [:Fallen] [:📆]]

Comment on attachment 8645864 [details] [diff] [review]
No-primaryToolbar-aero.patch

Review of attachment 8645864 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp with comment considered

::: mail/themes/windows/mail/primaryToolbar.css
@@ +1687,5 @@
> +      .appmenu-menuseparator {
> +        -moz-margin-start: 24px;
> +      }
> +    }
> +    @media (min-resolution: 2dppx) {

are nested media queries supported natively? I thought this was an scss/less feature.

Comment 3

[Richard Marti (:Paenglab)]

(In reply to Philipp Kewisch [:Fallen] from comment #2)
> Comment on attachment 8645864 [details] [diff] [review]
> No-primaryToolbar-aero.patch
> 
> are nested media queries supported natively? I thought this was an scss/less
> feature.

Yes this is supported and needed for something like this where is no other possibility: https://dxr.mozilla.org/comm-central/source/mozilla/browser/themes/windows/browser-aero.css#101

Comment 4

[Richard Marti (:Paenglab)]

http://hg.mozilla.org/comm-central/rev/fc0d1e7ffb92