Closed Bug 1192951 Opened 7 years ago Closed 7 years ago

Remove aero from the tree. Part 9 (primaryToolbar)

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Platform:
All
Windows
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 43.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

No-primaryToolbar-aero.patch
113.12 KB, patch
Fallen
: review+
Details | Diff | Splinter Review 
Remove primaryToolbar-aero.css.
This is only a copy from -aero to normal and adding the media queries with moving the the doubled rules to common rules.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8645864 - Flags: review?(philipp)
Comment on attachment 8645864 [details] [diff] [review]
No-primaryToolbar-aero.patch

Review of attachment 8645864 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp with comment considered

::: mail/themes/windows/mail/primaryToolbar.css
@@ +1687,5 @@
> +      .appmenu-menuseparator {
> +        -moz-margin-start: 24px;
> +      }
> +    }
> +    @media (min-resolution: 2dppx) {

are nested media queries supported natively? I thought this was an scss/less feature.
Attachment #8645864 - Flags: review?(philipp) → review+
(In reply to Philipp Kewisch [:Fallen] from comment #2)
> Comment on attachment 8645864 [details] [diff] [review]
> No-primaryToolbar-aero.patch
> 
> are nested media queries supported natively? I thought this was an scss/less
> feature.

Yes this is supported and needed for something like this where is no other possibility: https://dxr.mozilla.org/comm-central/source/mozilla/browser/themes/windows/browser-aero.css#101
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/fc0d1e7ffb92
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 43.0
You need to log in before you can comment on or make changes to this bug.