Remove aero from the tree. Part 11 (composer)

RESOLVED FIXED in Thunderbird 43.0

Status

Thunderbird
Theme
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 43.0
All
Windows

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Remove the composer aero files.
(Assignee)

Comment 1

2 years ago
Created attachment 8645866 [details] [diff] [review]
No-messengercompose-aero.patch

Again, this is only a copy from -aero to normal and adding the media queries with moving the the doubled rules to common rules.

Plus it's also renaming of a lot of icons which are used in composer and some remaining css files.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8645866 - Flags: review?(philipp)
Comment on attachment 8645866 [details] [diff] [review]
No-messengercompose-aero.patch

Review of attachment 8645866 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp with comment considered:

::: mail/themes/windows/jar.mn
@@ +195,5 @@
>    skin/classic/messenger/icons/flag-col.png                   (mail/icons/flag-col.png)
>    skin/classic/messenger/icons/flag-col.svg                   (mail/icons/flag-col.svg)
>    skin/classic/messenger/icons/flag.png                       (mail/icons/flag.png)
>    skin/classic/messenger/icons/flag-empty.png                 (mail/icons/flag-empty.png)
> +  skin/classic/messenger/icons/server-XP.png                  (mail/icons/server-XP.png)

Is the -XP suffix needed for these icons?
Attachment #8645866 - Flags: review?(philipp) → review+
(Assignee)

Comment 3

2 years ago
(In reply to Philipp Kewisch [:Fallen] from comment #2)
> Comment on attachment 8645866 [details] [diff] [review]
> No-messengercompose-aero.patch
> 
> Review of attachment 8645866 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=philipp with comment considered:
> 
> ::: mail/themes/windows/jar.mn
> @@ +195,5 @@
> >    skin/classic/messenger/icons/flag-col.png                   (mail/icons/flag-col.png)
> >    skin/classic/messenger/icons/flag-col.svg                   (mail/icons/flag-col.svg)
> >    skin/classic/messenger/icons/flag.png                       (mail/icons/flag.png)
> >    skin/classic/messenger/icons/flag-empty.png                 (mail/icons/flag-empty.png)
> > +  skin/classic/messenger/icons/server-XP.png                  (mail/icons/server-XP.png)
> 
> Is the -XP suffix needed for these icons?

Yes, in the aero section is a server-aero.png to server.png change to be consistent with FX. Both icons comes together in bug 1192954.
Keywords: checkin-needed
(Assignee)

Comment 4

2 years ago
http://hg.mozilla.org/comm-central/rev/9b84dabc464b
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 43.0
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.