1192983 - [Homescreen] Replace developer icons on homescreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P1)

Description

[Amy Lee [:amylee] UX]

Attachment: Homscreen_Dev_Icons.zip

Hi, 

Please update the developer icons on homescreen with the new ones provided in this bug. I've included icons for 3 and 4 column options. 

Please let me know if you need anything else.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] pivanov:bug-1192983 > mozilla-b2g:master

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Patryk,
can I ask you for r+ because I'm not sure who are the owners of these apps?

BTW: I talk with Amy over email about these changes and there are some changes. I will cc you in the email.

Comment 4

[Patryk Adamczyk [:patryk] UX]

Pavel, it would probably be best if someone from Homescreen r+ this bug.
Thanks!

Comment 5

[Chris Lord [:cwiiis]]

I don't think a homescreen peer is the right reviewer of this patch, but you can assume my r+ if you need it.

Comment 6

[Amy Lee [:amylee] UX]

Attachment: DevIcon_Default.zip

Hi Pavel, 

Can you also include this default icon for any app that doesn't have an updated icon? Also as discussed through email, please remove Mochitest and test-contain from the homescreen as these aren't accessed on the device. Thanks!

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks All.

Chris: I will :)

Amy: I will change all App Icons who have Blank.png for app icon

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Amy it's ready for ui-r?

Comment 9

[Amy Lee [:amylee] UX]

Hi Pavel, 

Can you send me a screenshot for me to review? Thanks!

Comment 10

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: Shot from Device

Here is the shot

Comment 11

[Amy Lee [:amylee] UX]

Hi Pavel, 

A 2 things:

1. I still see Mochitest and Test Container on home screen. Can you remove them (see comment 6)? 
2. Can you also replace the following with the default icon?

- Music NGA
- Mobile Wallet
- NFC APItests
- Device Storage, 
- Geoloc, 
- In-app Payments

Thanks!

Comment 12

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Yep.

for point 1. I think we should open another bug to remove these apps (not sure how to remove them we should ask someone for help)

for pont 2. Work on it now

Comment 13

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: Shot from Device

Comment 14

[Amy Lee [:amylee] UX]

(In reply to Pavel Ivanov [:ivanovpavel][:pivanov] from comment #13)
> Created attachment 8650717 [details]
> Shot from Device

Hi Pavel, 

Can you change Music NGA to the default icon? Thanks!

Comment 15

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Oh sorry I miss it ... it's fixed now.

Comment 16

[Chris Lord [:cwiiis]]

Comment on attachment 8647715 [details] [review]
patch for Gaia/master

Glancing over the icon changes, they all look fine, but there are changes to the css of the dev apps now, and I'm not the right person for that - sorry :(

Comment 17

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 8647715 [details] [review]
patch for Gaia/master

Oh ... thanks Chris ... for some reason I miss them when I rebase the patch. Can you take a look again. I think now we change only the images and manifest files

Comment 18

[Chris Lord [:cwiiis]]

Comment on attachment 8647715 [details] [review]
patch for Gaia/master

Changes look fine - it's a shame we couldn't put some of the duplicate icons in a shared location though.

Comment 19

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks! and yeah ... we have a lot of duplicate images :(

Comment 20

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :)

Landed in master:
https://github.com/mozilla-b2g/gaia/commit/02e9cf11db51d39e6c0b533b3aac5b09cc22c05f