1192986 - Various test_interfaces.html permafails since Gecko 41 was merged to Beta

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/logviewer.html#?job_id=451784&repo=mozilla-beta

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

We just need to remove some |release: false| entries.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

I check that the FontFace, FontFaceSet, and CSSFontFaceLoadEvent are legit.  Turns out that CSSFontFaceLoadEvent was renamed in the spec.  I filed bug 1193019 to get that fixed.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Fix test_interfaces.html to expect Cache API and font loading to be released. r=ehsan

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8645967 [details] [diff] [review]
Fix test_interfaces.html to expect Cache API and font loading to be released. r=ehsan

Approval Request Comment
[Feature/regressing bug #]: 1149381
[User impact if declined]: Beta build is red.
[Describe test coverage new/current, TreeHerder]: Mochitest verifies correct globals are exposed.  It was just not updated to expect these features to be released, but this was intentional.
[Risks and why]: Minimal.
[String/UUID change made/needed]: None

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8645967 [details] [diff] [review]
Fix test_interfaces.html to expect Cache API and font loading to be released. r=ehsan

Approval Request Comment
[Feature/regressing bug #]: 1149381
[User impact if declined]: Beta build is red.
[Describe test coverage new/current, TreeHerder]: Mochitest verifies correct globals are exposed.  It was just not updated to expect these features to be released, but this was intentional.
[Risks and why]: Minimal.
[String/UUID change made/needed]: None

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

Sorry, should have listed bug 1110144 as the regressing bug as well.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/fcd1df5faf39

This only needs to be on 41 Beta, right? 42 Aurora is fine?

Comment 8

[(no longer active)]

The patch should land on 42 Aurora as well.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8645967 [details] [diff] [review]
Fix test_interfaces.html to expect Cache API and font loading to be released. r=ehsan

Test-only changes don't need approval.

(In reply to Wes Kocher (:KWierso) from comment #7)
> This only needs to be on 41 Beta, right? 42 Aurora is fine?

Until the next cycle.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/68a7ebeeb75d

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Something here is still not quite right on beta: https://treeherder.mozilla.org/logviewer.html#?job_id=453936&repo=mozilla-beta


 806 INFO TEST-UNEXPECTED-FAIL | dom/workers/test/test_worker_interfaces.html | false: If this is failing: DANGER, are you sure you want to expose the new interface Cache to all webpages as a property on the worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) - expected PASS 
 807 INFO TEST-UNEXPECTED-FAIL | dom/workers/test/test_worker_interfaces.html | false: If this is failing: DANGER, are you sure you want to expose the new interface CacheStorage to all webpages as a property on the worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) - expected PASS

Comment 12

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Also mark Cache/CacheStorage as release interfaces on workers. r=ehsan a=bustage

The worker interface tests also need to understand Cache/CacheStorage are released.  Ehsan gave me r+ for this kind of change over IRC before he left.  I will land in beta/aurora/central.

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c6581fefb822

Comment 14

[Ben Kelly [:bkelly, not reviewing]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/09a386be3da2

Comment 15

[Ben Kelly [:bkelly, not reviewing]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0813c6add939

Comment 16

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7112863c43db

Comment 17

[Ben Kelly [:bkelly, not reviewing]]

Reopen until the changes land on m-c. (Right?)

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c6581fefb822
https://hg.mozilla.org/mozilla-central/rev/7112863c43db

Comment 19

[(no longer active)]

Do we also need this for the service worker interfaces test?

Comment 20

[Ben Kelly [:bkelly, not reviewing]]

(In reply to (Ask others for review please; out most of the week) from comment #19)
> Do we also need this for the service worker interfaces test?

Apparently not:

// IMPORTANT: Do not change this list without review from a DOM peer!
    "Cache",
// IMPORTANT: Do not change this list without review from a DOM peer!
    "CacheStorage",