1192987 - Upgrade from FF 39 to 40 changes verified add-on to unverified

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[Steven Harris]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/44.0.2403.130 Safari/537.36

Steps to reproduce:

Installed a verified add-on (ie. signed by AMO) into FF 39, then forced update to FF 40


Actual results:

The add-on that was listed as verified in FF 39 is now listed as unverified in FF 40


Expected results:

The add-on that was listed as verified in FF 39 should be unaffected by the upgrade of the browser to FF 40 and remain as verified

Comment 1

[Dave Townsend [:mossop]]

Firefox 39 doesn't check add-on signatures at all so it is possible that the add-on you're seeing this with is just always unverified.

I tried installing an add-on from AMO in 39 and then upgraded to 40 and Firefox showed the add-on as verified. Is there a specific add-on you're seeing this with?

Comment 2

[Steven Harris]

We have tried two groups of add-ons - ours, SoccerInferno and another's, Yahoo Toolbar, and both exhibited this behavior.

Comment 3

[Steven Harris]

One additional observation. The add-on that becomes unverified when upgraded from FF 39 to FF 40 is recognized as verified when directly installed into FF 40.

Comment 4

[Dave Townsend [:mossop]]

(In reply to Steven Harris from comment #2)
> We have tried two groups of add-ons - ours, SoccerInferno and another's,
> Yahoo Toolbar, and both exhibited this behavior.

Yahoo's toolbar  extension has code that modifies its install.rdf after installation, this breaks the signature of the add-on and so we're correctly flagging it as unverified after that.

I can't find your SoccerInferno add-on to look at, is it possible it does something similar? Any modification of the extensions files will cause signature verification to fail.

Comment 5

[Dave Townsend [:mossop]]

Closing as INVALID since the only example I can test with here is a known problem with the extension. If you are seeing this with your add-on and it isn't modifying itself in anyway then please reopen and let me know where I can get your add-on to test with.