Closed
Bug 1193023
Opened 9 years ago
Closed 9 years ago
Intermittent test_framerate_06.html | we should have 2 seconds worth of ticks, atleast 60 ticks
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(firefox41 unaffected, firefox42 fixed, firefox43 fixed, firefox-esr38 unaffected)
RESOLVED
FIXED
Firefox 43
Tracking | Status | |
---|---|---|
firefox41 | --- | unaffected |
firefox42 | --- | fixed |
firefox43 | --- | fixed |
firefox-esr38 | --- | unaffected |
People
(Reporter: KWierso, Assigned: jsantell)
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
1.36 KB,
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 20•9 years ago
|
||
Checking it out, it's a fragile test that really needs to be solidified
Assignee: nobody → jsantell
Component: Developer Tools → Developer Tools: Performance Tools (Profiler/Timeline)
Flags: needinfo?(jsantell)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 30•9 years ago
|
||
Attachment #8648504 -
Flags: review?(vporof)
Comment 31•9 years ago
|
||
Comment on attachment 8648504 [details] [diff] [review] 1193023-intermittent.patch Review of attachment 8648504 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/devtools/server/tests/mochitest/test_framerate_06.html @@ +64,5 @@ > // when we get ticks from other frames they're usually at diffs of < 1. Sometimes > // ticks can still be less than 16ms even on one frame (usually following a very slow > // frame), so use a low number (2) to be our threshold > var THRESHOLD = 2; > + ok(ticks.length >= 20, "we should have atleast 20 ticks over the course of two seconds."); Well, this is a stronger assumption, but still an assumption. Let's see how this goes.
Attachment #8648504 -
Flags: review?(vporof) → review+
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Comment 34•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cc3c25bf13e2
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Updated•9 years ago
|
status-firefox41:
--- → unaffected
status-firefox42:
--- → unaffected
status-firefox-esr38:
--- → unaffected
Comment hidden (Legacy TBPL/Treeherder Robot) |
Updated•9 years ago
|
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•