Closed Bug 1193035 Opened 5 years ago Closed 5 years ago
_development .py chokes on [devices] line in requires .txt
When we run 'python setup_development.py' it seems to chock on the requires.txt file of mozversion containing a line '[device]'. The file currently looks like this: mozfile >= 1.0 mozlog >= 3.0 [device] mozdevice >= 0.44 And the output we get from running setup_development.py is attached.
Summary: setup_development.py chocks on [devices] line in requires.txt → setup_development.py chokes on [devices] line in requires.txt
FYI I can repro this locally on my Linux machine, by running the following command in a local copy of the hello-e2e-tests (https://github.com/nils-ohlmeier/hello-e2e-tests.git): WORKSPACE=`pwd` HOME_LOCATION=~ ./setup.sh Note: this will requires clones of loop-server and loop-client to be locally available in the current working directory.
Likely related to bug 1189847.
Indeed, now that mozbase have optional dependencies, this script is failing. Here is a patch that fix the issue.
Assignee: nobody → j.parkouss
Status: NEW → ASSIGNED
Attachment #8646241 - Flags: review?(ahalberstadt)
Comment on attachment 8646241 [details] [diff] [review] 1193035.patch Review of attachment 8646241 [details] [diff] [review]: ----------------------------------------------------------------- This will always install optional dependencies, is that intended? If so r+. On a side note unrelated to this bug, it seems we should be able to replace setup_development.py with a clever enough root level requirements.txt. ::: testing/mozbase/setup_development.py @@ +91,5 @@ > + for line in file(requires): > + line = line.strip() > + # in requires.txt file, a dependency is a non empty line > + # Also lines like [device] are sections to mark optional > + # dependencies, we don't want that sections. nit: those sections
Attachment #8646241 - Flags: review?(ahalberstadt) → review+
(In reply to Andrew Halberstadt [:ahal] from comment #4) > This will always install optional dependencies, is that intended? If so r+. Well, this is what I intended. I suppose it is what we want since this is for installing required modules to work on mozbase (as far as I can understand). Anyway this is probably redundant because these optional deps are mozbase packages... But I think it won't hurt to let it this way. > On a side note unrelated to this bug, it seems we should be able to replace > setup_development.py with a clever enough root level requirements.txt. That would be great, from my point of view.
I fixed the nit. Forwarding r+ from ahal's review.
applying 1193035-8646396 cleaning up working directory...done abort: invalid date: 'mar. ao\xc3\xbbt 11 17:02:11 2015 +0200'
Julien, as this is affecting Hello's automated functional test runs, I fixed the patch up and pushed it for you (comment 8). It looks like you'd attached a 'hg log -l1 -p' or something which provides a different set of headers to the ones that 'hg qimport' likes.
Oh, thanks Mark. I think I did a 'hg commit -r . --patch' and redirected that to a file that I attached here. Usually it works, I will check that later (maybe you know a more appropriate command ?). Thanks for notifying. :)
You need to log in before you can comment on or make changes to this bug.