Closed Bug 1193086 Opened 4 years ago Closed 4 years ago

Remove some null checks of infallible new code in XUL

Categories

(Core :: XUL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8646651 [details] [diff] [review]
Remove some null checks of infallible new code in XUL.

Review of attachment 8646651 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/xul/nsXULCommandDispatcher.cpp
@@ +309,5 @@
>    }
>  #endif
>  
>    // If we get here, this is a new updater. Append it to the list.
>    updater = new Updater(aElement, aEvents, aTargets);

*link = new Updater(...
Attachment #8646651 - Flags: review?(amarchesini) → review+
(In reply to Andrea Marchesini (:baku) from comment #2)
> *link = new Updater(...

Fixed. Thanks for the reviews.
https://hg.mozilla.org/mozilla-central/rev/283c4c10df55
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.