1193099 - [Camera] Taking several pictures rapidly produces an error

Status: RESOLVED DUPLICATE of bug 1177110

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

If the user takes multiple pictures with the camera at a rapid rate, they will be presented with the error "Picture not saved. An error prevented Camera from saving the picture."

Repro Steps:
1) Update a Flame to 20150810142756.
2) Open the camera app. 
3) Take several pictures in a row by tapping the shutter button as fast as possible. (This is easier to reproduce with flash turned on or by using the volume and up buttons on the device)

Actual:
The user will be presented with the error "Picture not saved. An error prevented Camera from saving the picture" when taking several photos at a rapid rate.

Expected:
All pictures taken from the camera are saved properly without issue. 

Notes:

Environmental Variables:
Device: Aries 2.5
BuildID: 20150810142756
Gaia: fa89e03dc489e79baa0e74cb1d205260c7924caa
Gecko: cd45a38ded04
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Repro frequency: 100%
See attached: Logcat, Video

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue does occur on Flame Master

Taking pictures in a rapid succession produces an error. 

Device: Flame 2.5 (Full Flash)(KK)(319mb)
Build ID: 20150810053007
Gaia: fa89e03dc489e79baa0e74cb1d205260c7924caa
Gecko: cd45a38ded04
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 42.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0


This issue does not occur on Flame 2.2

The user cannot take photos in a rapid succession so no error message appears. 

Device: Flame 2.2 (Full Flash)(KK)(319mb)
Build ID: 20150810032504
Gaia: 102f1299e9eafe3760e1deb44d556b5c4f36b5af
Gecko: da29b5af4232
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: CameraErrorlog.txt

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

I thought I fixed this...

Comment 4

[Martin Shuman [:Marty]]

I was able to reproduce this issue back to the first Nightly Central build where the volume rockers can be used to take a picture. However, I am unable to reproduce this issue on builds prior to this, as I am unable to consistently reproduce the issue using only the touchscreen, which was mentioned by the bug reporter.

Environmental Variables:
Device: Flame 2.5
BuildID: 20150224160313
Gaia: f6bfd854fe4746f21bc006eac145365e85f98808
Gecko: 0a8b3b67715a
Version: 39.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Comment 5

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

I won't be able to finish this issue today, but there are 2 different issues in this bug.  The first is related to the volume rocker as Marty pointed out in comment 4 and occurs since that change was made.  

The second is Aries only and can be reproduced by continuously tapping the shutter button on the screen as long as the phone is plugged into a usb cable (does not need to be a computer, can just be a plug in the wall).

I have started the regression window for issue 2 but will not finish the inbound check today.  Here is the central window for now.

Central Regression Window:

Last Working 
Environmental Variables:
Device: Aries 2.5
BuildID: 20150622123157
Gaia: 311c4e59936a407e64509f54fecb440d8a78e3c8
Gecko: 20d8b6076d9b
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 41.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

First Broken 
Environmental Variables:
Device: Aries 2.5
BuildID: 20150624211040
Gaia: eb0d4aefa62b20420d6fa0642515a110daca5d97
Gecko: 7b0df70e27ea
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 41.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Last Working gaia / First Broken gecko - Issue does NOT occur
Gaia: 311c4e59936a407e64509f54fecb440d8a78e3c8
Gecko: 7b0df70e27ea

First Broken gaia / Last Working gecko - Issue DOES occur
Gaia: eb0d4aefa62b20420d6fa0642515a110daca5d97
Gecko: 20d8b6076d9b

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/311c4e59936a407e64509f54fecb440d8a78e3c8...eb0d4aefa62b20420d6fa0642515a110daca5d97

Comment 6

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

The changes for Bug 1176191 seems to have caused this issue.

B2g-inbound Regression Window

Last Working 
Environmental Variables:
Device: Aries 2.5
BuildID: 20150623003610
Gaia: c4d3b8fd78bcd7eff1b127060ec6490a891b7a35
Gecko: 2ab4034b2cc1
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 41.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

First Broken 
Environmental Variables:
Device: Aries 2.5
BuildID: 20150624023719
Gaia: eb0d4aefa62b20420d6fa0642515a110daca5d97
Gecko: 5a3ee6baf143
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 41.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Last Working gaia / First Broken gecko - Issue does NOT occur
Gaia: c4d3b8fd78bcd7eff1b127060ec6490a891b7a35
Gecko: 5a3ee6baf143

First Broken gaia / Last Working gecko - Issue DOES occur
Gaia: eb0d4aefa62b20420d6fa0642515a110daca5d97
Gecko: 2ab4034b2cc1

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/c4d3b8fd78bcd7eff1b127060ec6490a891b7a35...eb0d4aefa62b20420d6fa0642515a110daca5d97

Comment 7

[KTucker [:KTucker][Inactive 3/4/2016]]

Andrew, can you take a look at this please? This might have been caused by the landing for bug 1176191.

Comment 8

[Hsin-Yi Tsai (she/her)[:hsinyi]]

triage: 2.5+ as it's a regression

Comment 9

[Andrew Osmond [:aosmond] (he/him)]

I'm not sure how this is a regression of that particular bug. The root cause has been there since late 2014. But I can confirm it is fixed by bug 1177110 for for some reason never got requested to land despite being r+'d. I think it was when the treeherder gaia testing was on the fritz...