Active Accessibility: GetAccFocused() broken

VERIFIED FIXED in mozilla0.9.8

Status

SeaMonkey
General
P4
normal
VERIFIED FIXED
16 years ago
13 years ago

People

(Reporter: Aaron Leventhal, Assigned: Aaron Leventhal)

Tracking

({access, sec508})

Trunk
mozilla0.9.8
x86
Windows 2000
access, sec508

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: looking for r=, sr=)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

16 years ago
I noticed this while looking in the code the other day, we were using the old
method of QI'ing a frame to an accessible.
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Keywords: access, fcc508
Priority: -- → P4
Whiteboard: looking for r=, sr=
Target Milestone: --- → mozilla0.9.8
(Assignee)

Comment 1

16 years ago
Created attachment 64358 [details] [diff] [review]
Tested -- works

Comment 2

16 years ago
Hey, this looks good to me, but you've gotta start putting an explanation of
what is going on in the patches in your bugs.

Plus, is the last bit just some holdover from the bug fixing the tooltip text
problems from the other bug?
(Assignee)

Comment 3

16 years ago
Created attachment 64443 [details] [diff] [review]
New patch with irrelevant parts removed

GetAccFocused returns an accessible for the currently focused node. This fixes
the part of GetAccFocused that turns the node into an accessible.

In the old, old days of MSAA support, we used to QI nsIFrame to an
nsIAccessible. This was thought to be acceptable. These days, that QI always
fails. 

The new way is to use the GetAccessibleFor method, which takes a content node
and returns an nsIAccessible.
(Assignee)

Updated

16 years ago
Attachment #64358 - Attachment is obsolete: true

Comment 4

16 years ago
Comment on attachment 64443 [details] [diff] [review]
New patch with irrelevant parts removed

r=jgaunt
Attachment #64443 - Flags: review+

Comment 5

16 years ago
Comment on attachment 64443 [details] [diff] [review]
New patch with irrelevant parts removed

seems quite reasonable, and cleaner too :)
sr=alecf
Attachment #64443 - Flags: superreview+
(Assignee)

Comment 6

16 years ago
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 7

16 years ago
-- Tested GetAccFocused()for Html elements Link, Button, Checkbox, Radio 
Button, Select Combobox and Text Area. It works fine on all these html 
elements. Marking the bug as verified.
Status: RESOLVED → VERIFIED
QA Contact: doronr → dsirnapalli
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.