Closed
Bug 1193127
Opened 10 years ago
Closed 5 years ago
Fix task tracer output and compile error
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(firefox43 affected)
RESOLVED
INACTIVE
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | affected |
People
(Reporter: wcpan, Assigned: wcpan)
References
Details
Attachments
(1 file, 1 obsolete file)
|
17.86 KB,
patch
|
Details | Diff | Splinter Review |
Gecko failed to build if MOZ_TASK_TRACER=1.
Also fixes the JSON output format.
|
Assignee | |
Comment 1•10 years ago
|
||
Assignee: nobody → wpan
Attachment #8646124 -
Flags: review?(cyu)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8646124 [details] [diff] [review]
0001-fix-task-tracer.patch
Review of attachment 8646124 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for the patch. r=me with the following addressed.
::: xpcom/threads/TimerThread.cpp
@@ +19,5 @@
> #include "mozilla/BinarySearch.h"
> +#ifdef MOZ_TASK_TRACER
> +#include "GeckoTaskTracerImpl.h"
> +using namespace mozilla::tasktracer;
> +#endif
nit: Please add the #include before nIObserverService to maintain the alphabetical order of included files.
Attachment #8646124 -
Flags: review?(cyu) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Fixed. Also moved the using namespace after all headers.
Attachment #8646124 -
Attachment is obsolete: true
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
|
||
Comment 4•5 years ago
|
||
No activity in 2 years, this seems to be abandoned, closing.
Honza
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INACTIVE
You need to log in
before you can comment on or make changes to this bug.
Description
•