_getTxn() should take a callback and run the query in the same function loop

RESOLVED FIXED in FxOS-S5 (21Aug)

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: timdream, Assigned: timdream)

Tracking

unspecified
FxOS-S5 (21Aug)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:2.5+, b2g-master fixed)

Details

Attachments

(1 attachment)

This [1] rely on a incorrect behavior of Gecko, described in bug 1192160. We'll need to remove that before Gecko can fix it.

[1] https://github.com/mozilla-b2g/gaia/blob/84fc50c0b4da86de68ed82022b5f05c9968da0e5/apps/keyboard/js/shared/promise_storage.js#L87-L97
Assignee: nobody → timdream
Status: NEW → ASSIGNED
Created attachment 8646188 [details] [review]
[gaia] timdream:promise-txn > mozilla-b2g:master
Comment on attachment 8646188 [details] [review]
[gaia] timdream:promise-txn > mozilla-b2g:master

Jan, would you do the honor? For more information, read bug 1192160.

Not sure if this warrant a post on dev-gaia -- have not screen through the entire Gaia to see if there are other places with this pattern.
Attachment #8646188 - Flags: review?(janjongboom)
Bug 1179909 now triggers the behavior and PromiseStroage is currently broken on Nightly. We would need to get this landed soon.
Blocks: 1179909
blocking-b2g: --- → 2.5+
Comment on attachment 8646188 [details] [review]
[gaia] timdream:promise-txn > mozilla-b2g:master

Kyle, since Jan appears to be busy, would you mind review this patch for me? Thanks.
Attachment #8646188 - Flags: review?(khuey)
Attachment #8646188 - Flags: review?(janjongboom)
master: https://github.com/mozilla-b2g/gaia/commit/250c2f7af4ab4b55d7934f87562b0d0187bcb85f
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
status-b2g-master: --- → fixed
Target Milestone: --- → FxOS-S5 (21Aug)
You need to log in before you can comment on or make changes to this bug.