Closed
Bug 1193163
Opened 11 years ago
Closed 11 years ago
[JSDOC] write documentation of smart-home in jsdoc format
Categories
(Firefox OS Graveyard :: Gaia::TV::Home, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dwi2, Assigned: dwi2)
References
Details
Attachments
(1 file)
We need documentation of app-deck in jsdoc format. We'll focus on filter and pin-to-home in this bug. That means we need to add documentation for the following files:
1. card_filter.js
2. filter_manager.js
3. message_handler.js
4. connection_manager.js
And also describe the architecture of smart-home in README.md
| Assignee | ||
Updated•11 years ago
|
Assignee: nobody → tzhuang
Comment 1•11 years ago
|
||
| Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 8649074 [details] [review]
[gaia] dwi2:bug1193163 > mozilla-b2g:master
Hi Rex,
I added js doc for the following files
1. card_filter.js
2. filter_manager.js
3. message_handler.js
4. connection_manager.js
You could use |make docs| or |gulp jsdoc:smart-home| to generate js doc locally.
Also I fix some typo in jsdoc in other apps in tv_apps folder.
Please help to review it, thanks
Attachment #8649074 -
Flags: review?(rexboy)
Comment 3•11 years ago
|
||
Comment on attachment 8649074 [details] [review]
[gaia] dwi2:bug1193163 > mozilla-b2g:master
Looks good to me!
Attachment #8649074 -
Flags: review?(rexboy) → review+
| Assignee | ||
Comment 4•11 years ago
|
||
Thanks
Landed in master
https://github.com/mozilla-b2g/gaia/commit/86746c4db1810650644430d7797045721904cb61
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•