1193216 - The "log not found" error message should explain that it's due to the raw log having expired from eg ftp

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

Visit:
https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=2209625

Click an error line.

The following message is shown:
"Log could not be found"

Now since we have a text_log_summary for the log, we know that at some point the log file did exist (in fact, I think the whole log viewer breaks if the text_log_summary doesn't exist, so we don't need to worry about this case for the moment).

As such, "Log could not be found" is really "Log no longer exists". The former implies an issue with Treeherder, whereas it's really that the log source (eg ftp or the taskcluster hosts) has expired the log. We should also probably link to the log more obviously.

How about:

"The raw log no longer exists on <domain> - it may have expired."

...where the link text "<domain>" is the hostname from the log url, and the href is the full log URL.

Comment 1

[Mike Hommey [:glandium]]

Note that totally expired logs are even worse:

https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=8691877

(linked from bug 1124740)

Comment 2

[Ed Morley [:emorley]]

Yeah we should fix that case too. (Which is not that the log has expired, but the job data has been deleted from Treeherder by the cycle data task - the job basically doesn't exist any more).

Comment 3

[Jonathan French (:jfrench)]

Attachment: PR 867

Please see PR for status and review.

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/0ee01efc328989fcdb94861eab45f8d9562d236e
Bug 1193216 - Improve log not found notifications in logviewer

Comment 5

[Jonathan French (:jfrench)]

Marking fixed per above merge. Will verify on the next push to stage/prod. Note to self to re-check the console w/failure case on prod, ensuring the debug thNotify message doesn't appear there (setting debug false in my local env suppressed it as expected).

Comment 6

[Jonathan French (:jfrench)]

Verified fixed on stage with the failure case in comment 0, and should also be fixed on production for applicable jobs. I wasn't able to find any on production on some cursory searching.

We'll deal with completely expired jobs in bug 1193222, per above.