Closed
Bug 1193222
Opened 9 years ago
Closed 9 years ago
The log viewer should provide nicer error messages for expired/non existent job IDs
Categories
(Tree Management :: Treeherder, defect, P2)
Tree Management
Treeherder
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: emorley, Assigned: jfrench)
References
Details
Attachments
(1 file)
If visiting the log viewer and the requested job does not exist (either because an invalid ID was specified, or the job has since been expired due to the 4 month data retention policy), the UI fails to load properly and does not show an appropriate "The requests job does not exist (it may have expired)" type message. eg: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=8691877 https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=99999999999999999999999 Also, if no arguments are provided at all, the page is equally unhelpful: https://treeherder.mozilla.org/logviewer.html
|
Reporter | |
Updated•9 years ago
|
Summary: The log viewer should provide a nicer error message if the requested job does not exist → The log viewer should provide a nicer error messages for expired/non existent job IDs
|
|
Reporter | |
Updated•9 years ago
|
Summary: The log viewer should provide a nicer error messages for expired/non existent job IDs → The log viewer should provide nicer error messages for expired/non existent job IDs
|
Assignee | |
Comment 1•9 years ago
|
||
Assigning as part of the related work I've been doing here.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
|
|
Reporter | |
Updated•9 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 2•9 years ago
|
||
PR for review at your leisure :)
Attachment #8651078 -
Flags: review?(emorley)
|
|
Reporter | |
Comment 3•9 years ago
|
||
Comment on attachment 8651078 [details] [review] PR 895 Thank you :-)
Attachment #8651078 -
Flags: review?(emorley) → review+
|
||
Comment 4•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/e94fdf245515e4557a7f6bd1b874683ae9ba8d97 Bug 1193222 - Handle invalid logviewer jobs in the UI
|
|
Assignee | |
Comment 5•9 years ago
|
||
Marking fixed per above merge.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Component: Treeherder: Log Viewer → TreeHerder
You need to log in
before you can comment on or make changes to this bug.
Description
•