Closed Bug 1193222 Opened 6 years ago Closed 6 years ago

The log viewer should provide nicer error messages for expired/non existent job IDs

Categories

(Tree Management :: Treeherder: Log Viewer, defect, P2)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: emorley, Assigned: jfrench)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
emorley
: review+
Details | Review
If visiting the log viewer and the requested job does not exist (either because an invalid ID was specified, or the job has since been expired due to the 4 month data retention policy), the UI fails to load properly and does not show an appropriate "The requests job does not exist (it may have expired)" type message.

eg:
https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=8691877

https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=99999999999999999999999

Also, if no arguments are provided at all, the page is equally unhelpful:

https://treeherder.mozilla.org/logviewer.html
Summary: The log viewer should provide a nicer error message if the requested job does not exist → The log viewer should provide a nicer error messages for expired/non existent job IDs
Summary: The log viewer should provide a nicer error messages for expired/non existent job IDs → The log viewer should provide nicer error messages for expired/non existent job IDs
See Also: → 1193216
Blocks: 1182178
Assigning as part of the related work I've been doing here.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
Priority: -- → P2
Attached file PR 895
PR for review at your leisure :)
Attachment #8651078 - Flags: review?(emorley)
Comment on attachment 8651078 [details] [review]
PR 895

Thank you :-)
Attachment #8651078 - Flags: review?(emorley) → review+
Marking fixed per above merge.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Verified fixed on stage.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.