1193223 - Add reftest support to |mach test|

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[James Graham [:jgraham]]

So that |mach test path/to/directory| can find and run reftests in that directory.

Comment 1

[James Graham [:jgraham]]

Attachment: MozReview Request: Bug 1193223 - Add reftest support to mach test.

Bug 1193223 - Add reftest support to mach test.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8646444 [details]
MozReview Request: Bug 1193223 - Add reftest support to mach test.

https://reviewboard.mozilla.org/r/15757/#review14419

I guess this is based on some changes that haven't landed yet, but looks good to me.

::: testing/mach_commands.py:97
(Diff revision 1)
> -        'kwargs': {'test_file': None},
> +        'kwargs': {'tests': None},

Doesn't this need to be ```{'tests': []}``` for where you do ```kwargs["tests"].append(item["path"])``` in reftest/mach_commands.py ?

Comment 3

[James Graham [:jgraham]]

Comment on attachment 8646444 [details]
MozReview Request: Bug 1193223 - Add reftest support to mach test.

Bug 1193223 - Add reftest support to mach test.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d6532c1e99e

Comment 5

[Carsten Book [:Tomcat]]

sorry had to back this out in https://hg.mozilla.org/integration/mozilla-inbound/rev/5a8d86582839 since one of this changes caused https://treeherder.mozilla.org/logviewer.html#?job_id=13953993&repo=mozilla-inbound

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/985f984a97ad

Comment 7

[Nigel Babu [:nigelb]]

Had to back it out in https://hg.mozilla.org/integration/mozilla-inbound/rev/fa0a54cadfd0 for failures on Android 4.0 API11 reftests that look like this https://treeherder.mozilla.org/logviewer.html#?job_id=14037560&repo=mozilla-inbound

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/75b3c43770bd

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for breaking Android 4.0 debug reftests
https://hg.mozilla.org/integration/mozilla-inbound/rev/d90bfbc8688a

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a67faf13596

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4a67faf13596