Closed Bug 1193223 Opened 5 years ago Closed 5 years ago

Add reftest support to |mach test|

Categories

(Testing :: Reftest, defect)

defect
Not set
normal

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: jgraham, Unassigned)

Details

Attachments

(1 file)

So that |mach test path/to/directory| can find and run reftests in that directory.
Bug 1193223 - Add reftest support to mach test.
Attachment #8646444 - Flags: review?(cmanchester)
Comment on attachment 8646444 [details]
MozReview Request: Bug 1193223 - Add reftest support to mach test.

https://reviewboard.mozilla.org/r/15757/#review14419

I guess this is based on some changes that haven't landed yet, but looks good to me.

::: testing/mach_commands.py:97
(Diff revision 1)
> -        'kwargs': {'test_file': None},
> +        'kwargs': {'tests': None},

Doesn't this need to be ```{'tests': []}``` for where you do ```kwargs["tests"].append(item["path"])``` in reftest/mach_commands.py ?
Attachment #8646444 - Flags: review?(cmanchester) → review+
Comment on attachment 8646444 [details]
MozReview Request: Bug 1193223 - Add reftest support to mach test.

Bug 1193223 - Add reftest support to mach test.
https://hg.mozilla.org/mozilla-central/rev/4a67faf13596
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.