The "Native JS prototype extension" warning also matches things like: MappingTransformSelectDate.prototype.transform = function (field, secureValue)... because the type ends with "Date". We should match real native prototypes only.
Commits pushed to master at https://github.com/mozilla/amo-validator https://github.com/mozilla/amo-validator/commit/6cc260f7b23a4c3a45202ce8d7d135a6e2b7af30 Better regex matching for native JS prototype warning (bug 1193237) https://github.com/mozilla/amo-validator/commit/8f5d8640886ab38f3bdbcea39a9166f4bdd56eb8 Merge pull request #320 from wagnerand/bug1193237 Better regex matching for native JS prototype warning (bug 1193237)
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.