Closed Bug 1193257 Opened 5 years ago Closed 4 years ago

Allow passing general paths to tests on the command line and have xpcshell run them

Categories

(Testing :: XPCShell Harness, defect)

defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: jgraham, Unassigned)

References

Details

Attachments

(2 files, 1 obsolete file)

Instead of just paths to manifests.
Bug 1193257 - Make xpcshell harness command line arguments path filters for tests
Attachment #8646449 - Flags: review?(ahalberstadt)
Comment on attachment 8646449 [details]
MozReview Request: Bug 1193257, 1181516 - Update unittest mozconfigs for all platforms

Bug 1193257, 1181516 - Update unittest mozconfigs for all platforms
Attachment #8646449 - Attachment description: MozReview Request: Bug 1193257 - Make xpcshell harness command line arguments path filters for tests → MozReview Request: Bug 1193257, 1181516 - Update unittest mozconfigs for all platforms
Attachment #8646449 - Flags: review?(ahalberstadt) → review?(cmanchester)
Comment on attachment 8646449 [details]
MozReview Request: Bug 1193257, 1181516 - Update unittest mozconfigs for all platforms

Bug 1193257, 1181516 - Update unittest mozconfigs for all platforms
Comment on attachment 8646449 [details]
MozReview Request: Bug 1193257, 1181516 - Update unittest mozconfigs for all platforms

https://reviewboard.mozilla.org/r/15765/#review14211

Mozreview has this in a weird state - the two versions of the diff look unrelated, I can't really tell what to look at.
Attachment #8646449 - Flags: review?(cmanchester)
Attachment #8646449 - Attachment is obsolete: true
Bug 1193257 - Make xpcshell harness command line arguments path filters for tests
Attachment #8647440 - Flags: review?(ahalberstadt)
Comment on attachment 8647440 [details]
MozReview Request: Bug 1193257 - Make xpcshell harness command line arguments path filters for tests

https://reviewboard.mozilla.org/r/15985/#review14317

Awesome, thanks! Have you seen the mochitest implementation in mochitest_options.py? It basically does this but a little differently. Either way, this is a big improvement.

::: testing/xpcshell/remotexpcshelltests.py:500
(Diff revision 1)
> -class RemoteXPCShellOptions(xpcshell.XPCShellOptions):
> +def verifyRemoteOptions(parser, options):

There's an argument to be made for having the validation live alongside the definition. I don't feel that strongly about it though.

::: testing/xpcshell/runxpcshelltests.py:1073
(Diff revision 1)
> -        |testdirs|, if provided, is a list of absolute paths of test directories.
> +        |testsPath|, if provided, indicates a single path and/or test to run.

This can be a file or directory, right? The comment makes it seem like only test files can be specified.

::: testing/xpcshell/xpcshellcommandline.py:146
(Diff revision 1)
> +def parser_b2g():

Would be nice if common args and b2g args were in different ArgumentGroups. Changing "parser_common()" to "add_common_args(parser)" would make that possible. Ditto for remote.
Attachment #8647440 - Flags: review?(ahalberstadt) → review+
Comment on attachment 8647440 [details]
MozReview Request: Bug 1193257 - Make xpcshell harness command line arguments path filters for tests

Bug 1193257 - Make xpcshell harness command line arguments path filters for tests
Comment on attachment 8647440 [details]
MozReview Request: Bug 1193257 - Make xpcshell harness command line arguments path filters for tests

Bug 1193257 - Make xpcshell harness command line arguments path filters for tests
https://hg.mozilla.org/mozilla-central/rev/9dfa459ee7e5
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Depends on: 1206073
Turns out this bug requires a change for 'make xpcshell-tests' too.
Attachment #8665459 - Flags: review?(ahalberstadt)
Attachment #8665459 - Flags: review?(ahalberstadt) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d01fdb4df6a1d5a8ac99025537505ad9e0de69c
Bug 1193257 - Make xpcshell harness command line arguments path filters for tests: followup to fix 'make xpcshell-tests'. r=ahal
Keywords: checkin-needed
Depends on: 1225781
You need to log in before you can comment on or make changes to this bug.