1193271 - Submission of a LISTED add-on says that it will be automatically signed

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Mathieu Agopian [:magopian]]

Attachment: Screen Shot 2015-08-11 at 14.16.08.png

Submitting a listed add-on shouldn't never result in the message "Your submission passed validation and will be automatically signed."

You can reproduce this issue by uploading the add-on from https://addons.mozilla.org/fr/firefox/addon/french-holiday-forms/

It doesn't have any "signing severity" warnings above trivial, so it could pass the automatic validation, but as it's a listed add-on, it doesn't have automatic validation nor automatic signing.

Comment 1

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/652

If this lands, it'll need a LOT of QA on the addons submission process, the new version and new file forms and everything related (for listed and unlisted submissions).

We still don't have front-end tests to make sure there's no regressions, so touching this code is always dangerous.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/6032246554295589d47b37525b05a087a7af4d8e
Fix validation message (addon submission js code refactor) (bug 1193271)

https://github.com/mozilla/olympia/commit/27a35e706ccccfbc68865f2a7600961482ccacce
Merge pull request #652 from magopian/1193271-refactor-addon-submission-js

Fix validation message (addon submission js code refactor) (bug 1193271)

Comment 3

[Valentina Virlics [:vvalentina], VPN QA]

Verified on AMO-dev on FF40(Win 7).
Postfix screencasts:
- submitting a LISTED addon - http://screencast.com/t/TeHVQmPnk7
- upload a new file for a LISTED addon - http://screencast.com/t/6vZmNxA4j1
- upload a new version for a LISTED addon - http://screencast.com/t/Z4WgnzwQD5H

- submitting an UNLISTED addon - http://screencast.com/t/dCVXlQZYHV
- submitting a new version for an UNLISTED addon - http://screencast.com/t/ftnJ54wi6
- submitting a new file for an UNLISTED addon - http://screencast.com/t/oqBDc7gaSeyy

- submitting an UNLISTED-SIDELOADED addon - http://screencast.com/t/9rynzP5VUj
- submitting a new version for an UNLISTED-SIDELOADED addon - http://screencast.com/t/8cSEFSUJc8wD
- submitting a new file for an UNLISTED-SIDELOADED addon - http://screencast.com/t/ZndFY5ELw

Closing bug.

Comment 4

[Valentina Virlics [:vvalentina], VPN QA]

Verified also on Validator page, AMO-dev, FF40(Win 7)
- listed: http://screencast.com/t/5bzGTMwG2
- unlisted (missing the updateURL): http://screencast.com/t/vOo0An0x5 -> should display a message regarding review, like it does in a "normal submission": http://screencast.com/t/zCinlGIKFWF6

I don't know if that is the intended behavior.

Until further notice, I'll reopen.

Comment 5

[Mathieu Agopian [:magopian]]

Valentina, can you please attach the add-on you used to test? I can't reproduce the issue you're talking about regarding the missing message about the missing updateURL when submitting as unlisted. I tried on -dev and on production.

Comment 6

[Mathieu Agopian [:magopian]]

I understand now after discussing this over IRC: the checkbox with the message about the add-on not passing validation just above the submit button is expected on the "submission page": it's a confirmation that even if the unlisted add-on didn't pass automatic validation, you still want to go through a manual review.

This checkbox isn't useful on the standalone validator page because you can't submit an add-on from there.

So that's expected.

Comment 7

[Valentina Virlics [:vvalentina], VPN QA]

Verified on Validator page, AMO-stage FF40(Win 7) with updateURL missing:
- listed - http://screencast.com/t/x31XR7Qzn8x
- unlisted - http://screencast.com/t/MeLQrO0Om
- sideloaded - http://screencast.com/t/3UwTbwJVi

Verified using normal submission, AMO-stage FF40(Win 7) with updateURL missing:
- listed - http://screencast.com/t/GBkRiVhH
- unlisted - http://screencast.com/t/qkNqMrf1zOY
- sideloaded - http://screencast.com/t/ehKFAoeqc

Verified new file/new version, AMO-stage FF40(Win 7) with updateURL missing:
- listed - http://screencast.com/t/Onaep1P2 and http://screencast.com/t/XicipKx4Alqk
- unlisted - http://screencast.com/t/uInqfrFfc and http://screencast.com/t/nrMxQ6peN3D6
- sideloaded - http://screencast.com/t/gyf7rTzxfT and http://screencast.com/t/qJCoL0LPR

Also, taking in consideration comment 3, I'll put this bug as verified.
Closing bug.