1193289 - Add getUserMedia constraints tests for bug 1191298

Status: REOPENED

(Core :: WebRTC: Audio/Video, defect, P3)

Description

[Randell Jesup [:jesup] (needinfo me)]

Add tests for the case in bug 1191298.  This requires support in the fake cameras/loopback devices on the testers so this can be testable (bug 1088621).

Comment 1

[Maire Reavy [:mreavy]]

I'm much more comfortable with this being a P1 -- to get tests in (whether they are unit tests or mochitests).  I'd be fine with writing unit tests now to bridge the gap until we have support on the testers to write mochitests.

Comment 2

[Maire Reavy [:mreavy]]

Jan-Ivar - how hard would it be to add constraints to the fake devices, or to write a unit test (that has to run on a machine with real audio/video hardware)?

Assigning to Jan-Ivar for now

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I should be able to make them pretend to have capabilities fairly quickly. Whether the resulting output actually changes we'll have to see how easy/useful that is.

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

That's Bug 1088621 btw, which this bug depends on (I thought I was commenting on that one).

Comment 5

[Nils Ohlmeier [:drno]]

Is still relevant?

Comment 6

[Bulk Bug Changes for mreavy's org]

Mass change P1->P2 to align with new Mozilla triage process

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 8

[Dan Minor [:dminor]]

Guessing it is not still relevant, clearing old needinfo.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Er... do we have test coverage here? If not, how is this not relevant?

Comment 10

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

With bug 1537986, fake devices now have constrainable properties enough to satisfy wpt coverage for constraints, including for getSettings().

They don't cover all possible constraints, but doing so in a fake device give diminishing returns.

Comment 11

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Didn't mean to close it without discussion.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Jan-Ivar, if you're happy with the state of testing here, that works for me.

Comment 13

[Ginny Brown]

Attachment: same problem

Thanks from dwarostogum1972.