Closed Bug 119329 Opened 18 years ago Closed 18 years ago

Mac NSPR projects don't use tree-wide prefix files

Categories

(NSPR :: NSPR, defect)

PowerPC
Mac System 9.x
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sfraser_bugs, Assigned: sfraser_bugs)

Details

Attachments

(1 file)

NSPR doesn't use the tree-wide C/C++ prefix files that we use everywhere else, 
which means that NSPR ends up being built with different options (e.g. no 
traceback tables in opt builds). We should fix this.
Lack of NSPR symbols in Sampler trackes is a hindrance; I want to fix this.
Patch coming.
Status: NEW → ASSIGNED
Reviews please.
Comment on attachment 66358 [details] [diff] [review]
Patch to change the NSPR prefix files to use the mozilla tree-wide mac prefix files

r=pink
Attachment #66358 - Flags: review+
Comment on attachment 66358 [details] [diff] [review]
Patch to change the NSPR prefix files to use the mozilla tree-wide mac prefix files

This is going against our goal of eliminating NSPR's
dependence on the Mozilla client, but I won't insist
if this will help you debug Mac NSPR.
NSPR already depends on NSStdLib and NSRuntime libraries, whose projects include 
these same tree-wide prefix files, so I think the 'independence' argument is 
weak. A strong argument for using the same prefix files is that it ensures that 
all the libraries in the tree use the same compiler and optimization settings, 
thus ensuring compatibility.
You can go ahead and check this in.
Changes landed on NSPRPUB_PRE_4_2_CLIENT_BRANCH and the NSPR tip. I also migrated 
the XML project file to the tip, and removed 2 obsolete files: NSPR.toc, and 
NSPR.Debug.Prefix (replaced by NSPRDebug.Prefix).
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.