Closed Bug 1193311 Opened 4 years ago Closed 4 years ago

Enable eslint rules for Loop: eqeqeq (for content code)

Categories

(Hello (Loop) :: Client, defect)

defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Iteration:
43.1 - Aug 24
Tracking Status
firefox43 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [tech-debt])

Attachments

(1 file)

Enable the strict equals (eqeqeq) for content code in Loop.

We've been using this for a while in our content code and generally requiring it in review. I think its time that we switch the rule on.

For gecko code, we've generally been using the abstract equality (and I know there's been debates on the FF list about it), so I think for now we'll leave it off there and maybe have a discussion later at some stage.
Comment on attachment 8646358 [details] [diff] [review]
Enable eslint rules for Loop: eqeqeq (for content code.

Review of attachment 8646358 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good; r=dmose
Attachment #8646358 - Flags: review?(dmose) → review+
https://hg.mozilla.org/mozilla-central/rev/dfbcaf688a84
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Iteration: --- → 43.1 - Aug 24
You need to log in before you can comment on or make changes to this bug.