1193375 - Missing "Search" text in about:home / newtab search fields

Status: VERIFIED FIXED

(Firefox :: Search, defect, P3)

Description

[Petruta Horea [:phorea], Desktop Test Engineering]

Reproduced with 42.0a1 (2015-08-10), all platforms.

"Search" text is missing from the search fields on about:home and about:newtab pages.

It should be shown, according to design:
http://people.mozilla.org/~shorlander/mockups/InContent-SAPs/InContent-SAPs.html

Comment 1

[:shell escalante]

Stephen - is the mock-up old, kindof recalling the "search" was intentionally removed - the magnifying glass is the recognizable icon.

Comment 2

[Stephen Horlander [:shorlander]]

(In reply to :shell escalante from comment #1)
> Stephen - is the mock-up old, kindof recalling the "search" was
> intentionally removed - the magnifying glass is the recognizable icon.

No the mockup isn't old. Should have the "Search" placeholder text. Like the Search field in the toolbar currently has.

Comment 3

[:shell escalante]

Hi Madhava - Kev vaguely remembers the "Search" text being taken out on purpose... but it's in the mock-ups still and he wants to check your memory if the magnifying glass should replace or go in addition to the "search" text.

really just memory check - OK doing either.

Comment 4

[Francesco Lodolo [:flod]]

I think the string was just removed in bug 1190488, follow-up to bug 1171344.

Comment 5

[Stephen Horlander [:shorlander]]

(In reply to :shell escalante from comment #3)
> Hi Madhava - Kev vaguely remembers the "Search" text being taken out on
> purpose... but it's in the mock-ups still and he wants to check your memory
> if the magnifying glass should replace or go in addition to the "search"
> text.
> 
> really just memory check - OK doing either.

Not sure why it got removed in bug 1190488, but it should still be there. See comment 2.

Comment 6

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch

Sorry for the delay in getting to this.

Nothing wrong with bug 1190488, which removed the previous about:home-specific string from the DTD.

The problem was that contentSearchUI.js never set the placeholder string received from ContentSearch.jsm (the string comes from search.properties, which is also used by the toolbar searchbar).

Comment 7

[Drew Willcoxon :adw]

Comment on attachment 8653740 [details] [diff] [review]
Patch

Review of attachment 8653740 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Nihanth. :-)

Comment 8

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0210b58838c0

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/64335c640d78

Comment 10

[Nazir Ahmed Sabbir [:NaSb]]

Successfully reproduce this bug on Nightly 42.0a1 (2015-08-11) (Build ID: 20150811030206) with the instruction from comment 0 on Linux x64

This Bug is now verified as fixed on Latest Firefox Nightly 43.0a1 (2015-09-05)

Build ID: 20150905030205
Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0

Comment 11

[Petruta Horea [:phorea], Desktop Test Engineering]

Thanks Nazir! Marking as verified.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/64335c640d78