1193399 - flags argument of String.prototype.{search,match,replace} is deprecated

Status: RESOLVED FIXED

(Tree Management :: Bugherder, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Running Bugherder, I noticed the following warning in the console:

09:31:16.550 flags argument of String.prototype.{search,match,replace} is deprecated 1 UI.js:13:1


Apparently the extra "flags" parameter in replace is considered deprecated, and we should switch to using a regex if we need to use flags.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: PR 26

Comment 2

[Graeme McCutcheon [:graememcc]]

Comment on attachment 8646447 [details] [review]
PR 26

Much better. Thanks!

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://github.com/mozilla/bugherder/commit/2e4f156e7bc34e34335f25314a95d359af9202b3