Closed Bug 1193452 Opened 5 years ago Closed 3 years ago

Build on clang-cl without -fallback

Categories

(Firefox Build System :: General, defect)

42 Branch
defect
Not set

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: dmajor, Unassigned)

References

Details

Attachments

(1 file, 2 obsolete files)

clang-cl's -fallback switch is useful, but it may mask interesting build issues, and it reduces the amount of coverage we get in ASan builds.
I don't know if this will ever be land-able, but applying this patch locally has helped me find a few issues.
Depends on: 1193459
Depends on: 1193467
Depends on: 1193562
How many files do we roughly fall back on these days, out of curiosity?
We can be fallback-free if bug 1193562 is fixed. Otherwise, I don't recall offhand, somewhere in the hundreds maybe?
I believe this is possible now. I think ehsan should write a patch.
We no longer need this.  Or, at least, we will no longer need this once the
dependent NSS bug lands.
Attachment #8817484 - Flags: review?(mh+mozilla)
Attachment #8646523 - Attachment is obsolete: true
Comment on attachment 8817484 [details] [diff] [review]
don't use -fallback with clang-cl

Review of attachment 8817484 [details] [diff] [review]:
-----------------------------------------------------------------

Reflect the r+ I gave verbally during the All Hands.
Attachment #8817484 - Flags: review?(mh+mozilla) → review+
Rebased over recent changes.
Attachment #8820767 - Flags: review+
Attachment #8817484 - Attachment is obsolete: true
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/427341f59d73
don't use -fallback with clang-cl; r=glandium
https://hg.mozilla.org/mozilla-central/rev/427341f59d73
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.