Last Comment Bug 1193482 - Make gdataRequest backwards compatible again
: Make gdataRequest backwards compatible again
Status: RESOLVED FIXED
:
Product: Calendar
Classification: Client Software
Component: Provider: GData (show other bugs)
: Trunk
: Unspecified Unspecified
-- normal (vote)
: 4.4
Assigned To: Philipp Kewisch [:Fallen]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-08-11 12:41 PDT by Philipp Kewisch [:Fallen]
Modified: 2015-08-12 10:41 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Fix - v1 (1.94 KB, patch)
2015-08-11 13:36 PDT, Philipp Kewisch [:Fallen]
no flags Details | Diff | Splinter Review
Fix - v1 (1.94 KB, patch)
2015-08-11 13:39 PDT, Philipp Kewisch [:Fallen]
mohit.kanwal: review+
Details | Diff | Splinter Review

Description User image Philipp Kewisch [:Fallen] 2015-08-11 12:41:26 PDT
bug 1099592 fixed for nsILoadInfo, but this is not defined in TB31. This bug is to make it backwards compatible again.
Comment 1 User image Philipp Kewisch [:Fallen] 2015-08-11 13:36:51 PDT
Created attachment 8646557 [details] [diff] [review]
Fix - v1
Comment 2 User image Philipp Kewisch [:Fallen] 2015-08-11 13:39:00 PDT
Created attachment 8646558 [details] [diff] [review]
Fix - v1
Comment 3 User image Mohit Kanwal [:redDragon] 2015-08-11 19:13:26 PDT
Comment on attachment 8646558 [details] [diff] [review]
Fix - v1

Review of attachment 8646558 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Comment 4 User image aleth [:aleth] 2015-08-12 10:38:46 PDT
url:        https://hg.mozilla.org/comm-central/rev/2e390373ca65b260c892ef423df37a55f76d76d1
changeset:  2e390373ca65b260c892ef423df37a55f76d76d1
user:       Philipp Kewisch <mozilla@kewis.ch>
date:       Tue Aug 11 22:38:37 2015 +0200
description:
Bug 1193482 - Make gdataRequest backwards compatible again. r=redDragon

Note You need to log in before you can comment on or make changes to this bug.